-
Notifications
You must be signed in to change notification settings - Fork 20
Add JS for responsive tables in long text fields #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
markconroy
wants to merge
12
commits into
2.x
Choose a base branch
from
feature/759-responsive-tables
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4c4ad09
Add JS for responsive tables in long text fields
markconroy c02daae
Add CSS
markconroy 77ef640
Add theme setting for responsive tables
markconroy d5f1320
adds support for facet forms
markconroy 5f4a8df
adds more space between items
markconroy a51c952
Revert "Update .lgd-row classes to use CSS grid (#778)"
finnlewis 9426dac
Revert "adds more space between items"
finnlewis d95ec80
Revert "adds support for facet forms"
finnlewis 3d07056
Merge pull request #793 from localgovdrupal/feature/remove-duplicate-…
finnlewis 3a445d6
Merge branch '1.x' into feature/759-responsive-tables
finnlewis 881812b
Merge branch '2.x' into feature/759-responsive-tables
tonypaulbarker f618f1e
Remove repeated #default_value code of wysiwyg tables form
tonypaulbarker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.lgd-responsive-table { | ||
overflow-y: auto; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
/** | ||
* @file JS file for the responsive tables component. | ||
*/ | ||
|
||
(function responsiveTablesScript(Drupal, once) { | ||
Drupal.behaviors.responsiveTables = { | ||
attach(context) { | ||
const tables = []; | ||
const tablesInTextWithSummaryFields = once( | ||
'allResponsiveTables', | ||
'.field--type-text-with-summary table', | ||
context, | ||
); | ||
const tablesInTextLongFields = once( | ||
'responsiveTables', | ||
'.field--type-text-long table', | ||
context, | ||
); | ||
|
||
// Push all tables into the tables array. | ||
tables.push(...tablesInTextWithSummaryFields); | ||
tables.push(...tablesInTextLongFields); | ||
tables.forEach((table) => { | ||
// Clone the table to avoid modifying the original. | ||
const clonedTable = table.cloneNode(true); | ||
// Add a div around the cloned table. | ||
const wrapper = document.createElement('div'); | ||
wrapper.classList.add('lgd-responsive-table'); | ||
wrapper.appendChild(clonedTable); | ||
// Replace the original table with the wrapper. | ||
table.parentNode.replaceChild(wrapper, table); | ||
}); | ||
}, | ||
}; | ||
})(Drupal, once); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate
#default_value
with line 105 aboveUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markconroy @millnut line 107 has some additional logic compared to line 105. Presume we want line 107. "If we have this setting, use the setting, otherwise false" ?