Skip to content

Move restricted_width_content_types to .theme file #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2025

Conversation

markconroy
Copy link
Member

Closes #733

What does this change?

Moves the declaration of the restricted_widths_content_types from node--full.html.twig to localgov_base.theme so it's easier for subthemes to add to/remove from the array.

@markconroy markconroy requested review from ekes and finnlewis March 20, 2025 14:13
@finnlewis
Copy link
Member

@tonypaulbarker would like to test this.

@markconroy
Copy link
Member Author

@tonypaulbarker Any update on testing this? I'd like to get it accepted/rejected as soon as possible so I can keep working on the full view mode template for SDC.

@tonypaulbarker
Copy link

tonypaulbarker commented Mar 26, 2025

@markconroy half time report is this: I like the idea, I think it'll work, yet to carry out functional testing.

My early concern was for someone who has overridden the template in their sub-theme. Having examined the code I think it's going to be okay. If the array has been set in the template with a copy of the old code then those should still be the values used. And if the class isn't being used at all that's not a case we need be concerned about either.

@markconroy
Copy link
Member Author

@tonypaulbarker Great stuff, thanks. Can you mark this as approved when you get a chance to finish your testing? Thanks.

@tonypaulbarker tonypaulbarker self-requested a review March 27, 2025 20:35
@tonypaulbarker
Copy link

@markconroy it doesn't seem as though I have the permissions to approve this but approved subject to a check / remedy if needed of the two failing automated tests.

It seems events have been missing this class as they are using a specified template that doesn't set the variable. With the new code events do get the class. Not a blocker but worth noting for release notes.
I found some instances of content widths too narrow or too wide around the demo site already present and not related to this change. I'll file a new issue to look at those.

@markconroy markconroy merged commit 523d049 into 1.x Mar 28, 2025
10 of 12 checks passed
@markconroy
Copy link
Member Author

Thanks @tonypaulbarker, that's merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move restricted_width_content_types to localgov_base.theme
3 participants