-
Notifications
You must be signed in to change notification settings - Fork 20
adds template + CSS for contact compontent #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This got the 👍 from Clear Spot Media, #421 (comment) |
@ekes I've re-run the tests only failures are eslint and stylelint which I think have already been fixed on 1.x |
@markconroy - great! A couple of things:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markconroy looks like @msayoung has requested some changes, so we'll leave this with you for now.
To do
|
@msayoung I've completed checkbox 4 above, but the first three are config items not localgov_base items.
So ... I think this is ready to be approved and councils can remove those field labels showing in their own config and/or we can remove them by default in our other corresponding repos. |
@markconroy - sorry I'm still seeing extra padding above the Phone item. We've also lost space between the titles and fields. |
@msayoung this is ready again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
styles fine now, thanks.
One thing I noticed is that we're getting a heading for Email whether or not there is anything in that field. |
{% endif %} | ||
{% endfor %} | ||
</div> | ||
{% if has_email_website_fields %}{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is supposed to wrap the block above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, can't believe I made such a rookie mistake!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you left it to check my QA skills ;)
@msayoung ready again! |
All changes requested have been implemented.
* Add trailing comma * Add all font-awesome 6 icons * adds template + CSS for contact compontent (#695) * adds template + CSS for contact compontent * sets up variables for contact component CSS * fixes CSS coding standards * empty commit to trigger workflow * removes margin top from sibling contact groups * Add better spacing for items * Add if statement to correct place --------- Co-authored-by: Lee Mills <lee@leemills.dev> --------- Co-authored-by: Mark Conroy <mark@mark.ie> Co-authored-by: Lee Mills <lee@leemills.dev>
Closes #421
Note
This is not ready for testing just yet.
What does this change?
Adds a template + CSS for contact component.
Images
Before
After
Thanks to Big Blue Door for sponsoring my time to work on this.