Skip to content

adds template + CSS for contact compontent #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 15, 2025

Conversation

markconroy
Copy link
Member

@markconroy markconroy commented Dec 19, 2024

Closes #421

Note

This is not ready for testing just yet.

  • Wait to get designs from Designer Dave and see about implementing them
  • Update the CSS to use custom variables instead of generic ones.

What does this change?

Adds a template + CSS for contact component.

Images

Before

Screenshot 2024-12-19 at 12 57 03

After

Screenshot 2024-12-19 at 12 27 34


Thanks to Big Blue Door for sponsoring my time to work on this.

@markconroy markconroy marked this pull request as ready for review January 28, 2025 12:41
@markconroy
Copy link
Member Author

This got the 👍 from Clear Spot Media, #421 (comment)

@millnut
Copy link
Member

millnut commented Feb 4, 2025

@ekes I've re-run the tests only failures are eslint and stylelint which I think have already been fixed on 1.x

@finnlewis finnlewis self-assigned this Feb 11, 2025
@msayoung
Copy link
Member

@markconroy - great!

A couple of things:

  • the label for the Other team.localgov_contact.URL probably needs fixing
  • Repetition of the Office Hours heading and label
  • The Contact component title is showing above the component.
  • There's a bit more padding above the Phone heading, so its misaligned with Email and Website

Copy link
Member

@finnlewis finnlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markconroy looks like @msayoung has requested some changes, so we'll leave this with you for now.

@markconroy
Copy link
Member Author

markconroy commented Feb 20, 2025

To do

  • the label for the Other team.localgov_contact.URL probably needs fixing
  • Repetition of the Office Hours heading and label
  • The Contact component title is showing above the component.
  • There's a bit more padding above the Phone heading, so its misaligned with Email and Website

@markconroy
Copy link
Member Author

@msayoung I've completed checkbox 4 above, but the first three are config items not localgov_base items.

the label for the Other team.localgov_contact.URL probably needs fixing
Repetition of the Office Hours heading and label
The Contact component title is showing above the component.

So ... I think this is ready to be approved and councils can remove those field labels showing in their own config and/or we can remove them by default in our other corresponding repos.

@markconroy markconroy requested a review from finnlewis February 25, 2025 10:24
@msayoung
Copy link
Member

@markconroy - sorry I'm still seeing extra padding above the Phone item. We've also lost space between the titles and fields.

@markconroy
Copy link
Member Author

@msayoung this is ready again.

@msayoung msayoung self-requested a review April 10, 2025 12:43
Copy link
Member

@msayoung msayoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

styles fine now, thanks.

@msayoung
Copy link
Member

One thing I noticed is that we're getting a heading for Email whether or not there is anything in that field.

{% endif %}
{% endfor %}
</div>
{% if has_email_website_fields %}{% endif %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is supposed to wrap the block above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, can't believe I made such a rookie mistake!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you left it to check my QA skills ;)

@markconroy
Copy link
Member Author

@msayoung ready again!

@markconroy markconroy dismissed finnlewis’s stale review April 15, 2025 15:04

All changes requested have been implemented.

@markconroy markconroy merged commit 675e6c9 into 1.x Apr 15, 2025
6 of 12 checks passed
markconroy added a commit that referenced this pull request Apr 15, 2025
* Add trailing comma

* Add all font-awesome 6 icons

* adds template + CSS for contact compontent (#695)

* adds template + CSS for contact compontent

* sets up variables for contact component CSS

* fixes CSS coding standards

* empty commit to trigger workflow

* removes margin top from sibling contact groups

* Add better spacing for items

* Add if statement to correct place

---------

Co-authored-by: Lee Mills <lee@leemills.dev>

---------

Co-authored-by: Mark Conroy <mark@mark.ie>
Co-authored-by: Lee Mills <lee@leemills.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add styling to the contact component
4 participants