Skip to content

1.7.0 release #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 57 commits into from
Oct 15, 2024
Merged
Show file tree
Hide file tree
Changes from 49 commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
d486f69
sets color for dialog backdrop and margin for dialog
markconroy Aug 6, 2024
f18e1fc
sets margin for dialog
markconroy Aug 6, 2024
c692733
Use shared Github workflows
stephen-cox Aug 6, 2024
65d36fa
Merge pull request #582 from localgovdrupal/fix/1.x/user-shared-workf…
stephen-cox Aug 8, 2024
c5be885
Merge pull request #583 from localgovdrupal/1.x
finnlewis Aug 13, 2024
ed97266
Adds a variable to let us print a token for replacement in the breadc…
rupertj Aug 13, 2024
f6865f2
Merge pull request #581 from localgovdrupal/fix/580/alert-banner-dialog
finnlewis Aug 13, 2024
d5d6c3c
Merge pull request #585 from localgovdrupal/feature/1.x/584-breadcrum…
markconroy Aug 15, 2024
cfc7d34
adds better focus orders for services button/menu
markconroy Aug 16, 2024
84432f1
feat: replaces standalone prev-next code with included version
ctorgalson Aug 21, 2024
e5752d6
fix: swaps double quotes for single quotes for project consistency
ctorgalson Aug 21, 2024
baf7610
Add tabindex -1 to skip link target
anthonylindsay Aug 22, 2024
8c73c11
Merge pull request #589 from anthonylindsay/202408_skiplink_tabindex
markconroy Aug 22, 2024
e9c9ea8
fix: ensures no colon rendered in prev/next links unless a title is set
ctorgalson Aug 22, 2024
34db467
feat: adds back-to-top link them setting and page variable
ctorgalson Aug 26, 2024
cfb9d31
feat: adds new back-to-top js, css, twig template and libraries entry
ctorgalson Aug 26, 2024
e7e4e8e
feat: places back-to-top include in page.html.twig
ctorgalson Aug 26, 2024
537cbac
feat: adds icon to back-to-top button
ctorgalson Aug 26, 2024
a356288
feat: completes css for back-to-top link
ctorgalson Aug 26, 2024
64bdd0e
Merge pull request #586 from localgovdrupal/fix/578-header-services-b…
markconroy Aug 26, 2024
d1da494
Merge pull request #588 from localgovdrupal/565_use_prev_next_twig_fo…
markconroy Aug 26, 2024
160e4f3
adds empty alt text for start icon button
markconroy Aug 26, 2024
02d8328
feat: explicitly set target dimensions to smallest possible
ctorgalson Aug 26, 2024
ad7bbb6
feat: re-hide the link on click
ctorgalson Aug 26, 2024
eafd219
feat: completes docs, moves various values to vars (anticipating SDC)
ctorgalson Aug 26, 2024
ba3707e
feat: makes default hidden attr value "until-found"
ctorgalson Aug 26, 2024
74f0c34
fix: matches project quote style
ctorgalson Aug 26, 2024
45fea15
fix: matches project quote style
ctorgalson Aug 26, 2024
810314f
feat: localgov_base override of book-navigation--publication.html.twig
ctorgalson Aug 26, 2024
d1c1699
Merge pull request #596 from localgovdrupal/564-use-prev-next-twig-fo…
markconroy Aug 28, 2024
a68d722
Merge branch '1.x' into 312-add-back-to-top-button
markconroy Aug 29, 2024
019e481
fixes typo
markconroy Aug 29, 2024
5149888
Merge pull request #595 from localgovdrupal/312-add-back-to-top-button
markconroy Aug 29, 2024
e6c8082
Merge pull request #594 from localgovdrupal/427/fix/stop-jaws-reading…
markconroy Sep 3, 2024
7238b24
feat: add expand/collapse icon to accordion
millnut Sep 14, 2024
8762135
feat: add expand/collapse icon to accordion
millnut Sep 14, 2024
bd084bf
fix: set color on service status heading
millnut Sep 14, 2024
a38be8c
hides guides/steps navigation in print mode
markconroy Sep 23, 2024
d33856e
adds CSS for blockquotes created via WYSIWYG
markconroy Sep 23, 2024
2b5da22
ensures quick fact content is inside a <p> tag
markconroy Sep 23, 2024
b2a1254
uses variable for accordion icon
markconroy Sep 23, 2024
dd2572f
adds more space for clickable area for pager items
markconroy Sep 23, 2024
928c53e
formatting code
markconroy Sep 24, 2024
1c66e02
adds alt text for map opening in new tab
markconroy Sep 24, 2024
a1362aa
Merge pull request #617 from localgovdrupal/fix/607/quick-fact-semantics
ekes Sep 24, 2024
2028da7
Merge pull request #616 from localgovdrupal/fix/611/blockquote-wysiwyg
ekes Sep 24, 2024
3833ab0
Merge pull request #615 from localgovdrupal/feature/614/hide-guides-s…
ekes Sep 24, 2024
66ec604
Merge pull request #603 from localgovdrupal/feature/1.x/add-expand-co…
ekes Sep 24, 2024
671d694
Merge pull request #619 from localgovdrupal/fix/618/page-target-area
ekes Sep 24, 2024
19a463a
Merge pull request #604 from localgovdrupal/fix/1.x/set-color-on-serv…
ekes Sep 24, 2024
77a749e
sticky header settings for localgov_base (#569)
markconroy Sep 24, 2024
aa313c9
Merge pull request #620 from localgovdrupal/fix/612/alt-text-service-…
markconroy Sep 24, 2024
d563ab4
Fixes #366 - text overlapping Guide Nav (#625)
mccrodp Oct 1, 2024
7ffc23a
Fix config schema error #629 (#630)
stephen-cox Oct 2, 2024
ae91066
removes localgov_base_helper module (#632)
markconroy Oct 15, 2024
0e70057
Adds support for facet forms (#634)
markconroy Oct 15, 2024
6b5cac7
Adds empty breadcrumbs block for use by microsites_base (#636)
markconroy Oct 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
206 changes: 6 additions & 200 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,205 +7,11 @@ on:
pull_request:
branches:
- '1.x'

env:
LOCALGOV_DRUPAL_PROJECT: localgovdrupal/localgov_base
LOCALGOV_DRUPAL_PROJECT_PATH: web/themes/contrib/localgov_base
workflow_dispatch:

jobs:

build:
name: Install LocalGov Drupal
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
localgov-version:
- '3.x'
drupal-version:
- '~10.0'
php-version:
- '8.1'
- '8.2'

steps:

- name: Save git branch and git repo names to env if this is not a pull request
if: github.event_name != 'pull_request'
run: |
echo "GIT_BASE=${GITHUB_REF#refs/heads/}" >> $GITHUB_ENV
echo "GIT_BRANCH=${GITHUB_REF#refs/heads/}" >> $GITHUB_ENV
echo "HEAD_USER=localgovdrupal" >> $GITHUB_ENV

- name: Save git branch and git repo names to env if this is a pull request
if: github.event_name == 'pull_request'
run: |
echo "GIT_BASE=${GITHUB_BASE_REF}" >> $GITHUB_ENV
echo "GIT_BRANCH=${GITHUB_HEAD_REF}" >> $GITHUB_ENV
export HEAD="${{ github.event.pull_request.head.label }}"
echo "HEAD_USER=${HEAD%%:*}" >> $GITHUB_ENV

- name: Set composer branch reference for version branches
if: endsWith(github.ref, '.x')
run: echo "COMPOSER_REF=${GIT_BRANCH}-dev" >> $GITHUB_ENV

- name: Set composer branch reference for non-version branches
if: endsWith(github.ref, '.x') == false
run: echo "COMPOSER_REF=dev-${GIT_BRANCH}" >> $GITHUB_ENV

- name: Get the latest tagged release for branch version
run: |
LATEST_RELEASE=$(curl -H "Accept: application/vnd.github.v3+json" https://api.github.com/repos/${GITHUB_REPOSITORY}/git/matching-refs/tags/${GIT_BASE%'.x'} | grep -Po '(?<=refs/tags/)[^"]+' | tail -1)
if [ -z $LATEST_RELEASE ]; then LATEST_RELEASE=1; fi
echo "LATEST_RELEASE=${LATEST_RELEASE}" >> $GITHUB_ENV

- name: Cached workspace
uses: actions/cache@v2
with:
path: ./html
key: localgov-build-${{ matrix.localgov-version }}-${{ matrix.drupal-version }}-${{ matrix.php-version }}-${{ github.run_id }}-${{ secrets.CACHE_VERSION }}

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}

- name: Clone drupal_container
uses: actions/checkout@v2
with:
repository: localgovdrupal/drupal-container
ref: php${{ matrix.php-version }}

- name: Create LocalGov Drupal project
run: |
composer create-project --stability dev --no-install localgovdrupal/localgov-project ./html "${{ matrix.localgov-version }}"
composer --working-dir=./html require --no-install localgovdrupal/localgov:${{ matrix.localgov-version }}-dev
composer --working-dir=./html require --no-install drupal/core-recommended:${{ matrix.drupal-version }} drupal/core-composer-scaffold:${{ matrix.drupal-version }} drupal/core-project-message:${{ matrix.drupal-version }} drupal/core-dev:${{ matrix.drupal-version }}
composer --working-dir=./html install

- name: Obtain the test target using Composer
if: env.HEAD_USER == 'localgovdrupal'
run: |
composer --working-dir=html config repositories.1 vcs git@github.com:${LOCALGOV_DRUPAL_PROJECT}.git
composer global config github-oauth.github.com ${{ github.token }}
composer --working-dir=./html require --with-all-dependencies ${LOCALGOV_DRUPAL_PROJECT}:"${COMPOSER_REF} as ${LATEST_RELEASE}"

- name: Obtain the test target using Git
if: env.HEAD_USER != 'localgovdrupal'
uses: actions/checkout@v2
with:
path: ${{ env.LOCALGOV_DRUPAL_PROJECT_PATH }}

phpcs:
name: Coding standards checks
needs: build
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
localgov-version:
- '3.x'
drupal-version:
- '~10.0'
php-version:
- '8.1'
- '8.2'

steps:

- name: Cached workspace
uses: actions/cache@v2
with:
path: ./html
key: localgov-build-${{ matrix.localgov-version }}-${{ matrix.drupal-version }}-${{ matrix.php-version }}-${{ github.run_id }}-${{ secrets.CACHE_VERSION }}
restore-keys: |
localgov-build-${{ matrix.localgov-version }}-${{ matrix.drupal-version }}-${{ matrix.php-version }}-

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}

- name: Run coding standards checks
run: |
cd html
./bin/phpcs -p ${LOCALGOV_DRUPAL_PROJECT_PATH}

phpstan:
name: Deprecated code checks
needs: build
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
localgov-version:
- '3.x'
drupal-version:
- '~10.0'
php-version:
- '8.1'
- '8.2'

steps:

- name: Cached workspace
uses: actions/cache@v2
with:
path: ./html
key: localgov-build-${{ matrix.localgov-version }}-${{ matrix.drupal-version }}-${{ matrix.php-version }}-${{ github.run_id }}-${{ secrets.CACHE_VERSION }}
restore-keys: |
localgov-build-${{ matrix.localgov-version }}-${{ matrix.drupal-version }}-${{ matrix.php-version }}-

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}

- name: Run deprecated code checks
run: |
cd html
./bin/phpstan analyse -c ./phpstan.neon ${LOCALGOV_DRUPAL_PROJECT_PATH}
phpunit:
name: PHPUnit tests
needs: build
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
localgov-version:
- '3.x'
drupal-version:
- '~10.0'
php-version:
- '8.1'
- '8.2'

steps:

- name: Clone Drupal container
uses: actions/checkout@v2
with:
repository: localgovdrupal/drupal-container
ref: php${{ matrix.php-version }}

- name: Cached workspace
uses: actions/cache@v2
with:
path: ./html
key: localgov-build-${{ matrix.localgov-version }}-${{ matrix.drupal-version }}-${{ matrix.php-version }}-${{ github.run_id }}-${{ secrets.CACHE_VERSION }}
restore-keys: |
localgov-build-${{ matrix.localgov-version }}-${{ matrix.drupal-version }}-${{ matrix.php-version }}-

- name: Start Docker environment
run: docker-compose -f docker-compose.yml up -d

- name: Run PHPUnit tests
run: |
mkdir -p ./html/web/sites/simpletest && chmod 777 ./html/web/sites/simpletest
sed -i "s#http://localgov.lndo.site#http://drupal#" ./html/phpunit.xml.dist
docker exec -t drupal bash -c 'chown docker:docker -R /var/www/html'
docker exec -u docker -t drupal bash -c "cd /var/www/html && ./bin/paratest --processes=4 /var/www/html/${{ env.LOCALGOV_DRUPAL_PROJECT_PATH }}"
tests:
uses: localgovdrupal/localgov_shared_workflows/.github/workflows/test-module.yml@1.x
with:
project: 'localgovdrupal/localgov_base'
project_path: 'web/themes/contrib/localgov_base'
1 change: 1 addition & 0 deletions config/install/localgov_base.settings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ localgov_base_remove_css: FALSE
localgov_base_remove_js: FALSE
localgov_base_add_unpublished_background_colour: TRUE
localgov_base_add_draft_note_to_unpublished_content: FALSE
localgov_base_header_behaviour: 'default'
9 changes: 9 additions & 0 deletions config/schema/localgov_base.schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,12 @@ localgov_base.settings:
localgov_base_add_draft_note_to_unpublished_content:
type: boolean
label: 'Add "[Draft]" to title of unpublished content.'
localgov_base_header_behaviour:
type: enum
label: 'Header behaviour'
description: 'Choose whether the header should be sticky or not.'
default: 'default'
options:
'default': 'Default - scrolls away with the page'
'sticky': 'Sticky - remains at the top of the page'
'appears_on_scroll': 'Scroll - appears when scrolling up'
11 changes: 11 additions & 0 deletions css/base/base.css
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ html {
margin-top: 0; /* Removing top margin, for better vertical rhythm layout */
}

dialog {
margin: auto;
}

body {
margin: 0;
color: var(--color-text);
Expand Down Expand Up @@ -158,6 +162,13 @@ ol ul {
margin-bottom: 0;
}

blockquote:not(.pull-out-quote__content) {
padding-inline-start: var(--quote-padding);
padding-left: var(--quote-padding-left);
border-inline-start: var(--quote-border);
border-color: var(--color-accent);
}

sub,
sup {
position: relative;
Expand Down
2 changes: 1 addition & 1 deletion css/base/ckeditor5.css
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
position: relative;
top: 7px;
margin-left: 0.5rem;
content: "\203A";
content: "\203A" / "";
font-size: 2.875rem;
}

Expand Down
7 changes: 7 additions & 0 deletions css/base/variables.css
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,9 @@ body {

/* Animation */
--transition-time: 0.3s;

/* Dialog */
--dialog-backdrop-color: rgba(0, 0, 0, 0.8);
}

/*
Expand Down Expand Up @@ -540,4 +543,8 @@ body {
--add-to-calendar-dialog-backdrop-opacity: 0.75;
--add-to-calendar--icon-color: var(--color-white);
--add-to-calendar--icon-color-hover: var(--color-accent);

/* Accordion */
--accordion-icon-closed: "+";
--accordion-icon-opened: "-";
}
33 changes: 33 additions & 0 deletions css/components/accordion.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/**
* @file
* Style rules for accordions.
*/

/* Default */
.accordion-pane__title button {
display: inline-flex;
align-items: center;
justify-content: space-between;
}

.accordion-pane__title button:hover,
.accordion-pane__title button:focus {
text-decoration: none;
}

.accordion-icon {
display: block;
}

span.accordion-icon::after {
display: block;
font-size: 150%;
}

.accordion-pane__title button[aria-expanded="false"] > .accordion-icon::after {
content: var(--accordion-icon-closed);
}

.accordion-pane__title button[aria-expanded="true"] > .accordion-icon::after {
content: var(--accordion-icon-opened);
}
8 changes: 8 additions & 0 deletions css/components/alert-banner.css
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@
background-color: var(--alert-banner-bg-color);
}

dialog.localgov-alert-banner {
margin: auto;
}

dialog.localgov-alert-banner::backdrop {
background-color: var(--dialog-backdrop-color);
}

.localgov-alert-banner,
.localgov-alert-banner a {
color: var(--alert-banner-color);
Expand Down
41 changes: 41 additions & 0 deletions css/components/back-to-top.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
.back-to-top {
background: var(--button-link-bg-color);
border: 3px solid var(--color-white);
bottom: 2em;
color: var(--button-link-color);
display: flex;
font-weight: bold;
gap: var(--spacing-small);
padding: var(--button-link-padding);
position: fixed;
right: 2em;
text-decoration: none;
transition: var(--transition-time);
opacity: 1;
}

.back-to-top[hidden] {
opacity: 0;
}

.back-to-top:hover,
.back-to-top:focus {
text-decoration: underline;
}

.back-to-top__icon svg path {
fill: currentcolor;
}

.back-to-top-target {
max-height: 1px;
max-width: 1px;
overflow: hidden;
}

@media screen and (min-width: 48rem) {
.back-to-top {
bottom: 5em;
right: 5em;
}
}
2 changes: 1 addition & 1 deletion css/components/header.css
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
.lgd-header__toggle-icon::after {
display: inline-block;
margin-left: var(--spacing-smaller);
content: "\203A";
content: "\203A" / "";
transition: var(--transition-time);
transform: rotate(90deg);
font-size: var(--font-size-larger);
Expand Down
4 changes: 4 additions & 0 deletions css/components/pager.css
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,7 @@
.pager__item::marker {
color: transparent;
}

.pager__item > a {
padding-inline: var(--spacing-smaller);
}
2 changes: 1 addition & 1 deletion css/components/quote.css
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
padding: var(--quote-padding);
padding-left: var(--quote-padding-left);
border-color: var(--quote-border-color);
border-left: var(--quote-border);
border-inline-start: var(--quote-border);
background-color: var(--quote-bg-color);
}

Expand Down
Loading
Loading