-
Notifications
You must be signed in to change notification settings - Fork 20
1.7.0 release #622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
1.7.0 release #622
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
d486f69
sets color for dialog backdrop and margin for dialog
markconroy f18e1fc
sets margin for dialog
markconroy c692733
Use shared Github workflows
stephen-cox 65d36fa
Merge pull request #582 from localgovdrupal/fix/1.x/user-shared-workf…
stephen-cox c5be885
Merge pull request #583 from localgovdrupal/1.x
finnlewis ed97266
Adds a variable to let us print a token for replacement in the breadc…
rupertj f6865f2
Merge pull request #581 from localgovdrupal/fix/580/alert-banner-dialog
finnlewis d5d6c3c
Merge pull request #585 from localgovdrupal/feature/1.x/584-breadcrum…
markconroy cfc7d34
adds better focus orders for services button/menu
markconroy 84432f1
feat: replaces standalone prev-next code with included version
ctorgalson e5752d6
fix: swaps double quotes for single quotes for project consistency
ctorgalson baf7610
Add tabindex -1 to skip link target
anthonylindsay 8c73c11
Merge pull request #589 from anthonylindsay/202408_skiplink_tabindex
markconroy e9c9ea8
fix: ensures no colon rendered in prev/next links unless a title is set
ctorgalson 34db467
feat: adds back-to-top link them setting and page variable
ctorgalson cfb9d31
feat: adds new back-to-top js, css, twig template and libraries entry
ctorgalson e7e4e8e
feat: places back-to-top include in page.html.twig
ctorgalson 537cbac
feat: adds icon to back-to-top button
ctorgalson a356288
feat: completes css for back-to-top link
ctorgalson 64bdd0e
Merge pull request #586 from localgovdrupal/fix/578-header-services-b…
markconroy d1da494
Merge pull request #588 from localgovdrupal/565_use_prev_next_twig_fo…
markconroy 160e4f3
adds empty alt text for start icon button
markconroy 02d8328
feat: explicitly set target dimensions to smallest possible
ctorgalson ad7bbb6
feat: re-hide the link on click
ctorgalson eafd219
feat: completes docs, moves various values to vars (anticipating SDC)
ctorgalson ba3707e
feat: makes default hidden attr value "until-found"
ctorgalson 74f0c34
fix: matches project quote style
ctorgalson 45fea15
fix: matches project quote style
ctorgalson 810314f
feat: localgov_base override of book-navigation--publication.html.twig
ctorgalson d1c1699
Merge pull request #596 from localgovdrupal/564-use-prev-next-twig-fo…
markconroy a68d722
Merge branch '1.x' into 312-add-back-to-top-button
markconroy 019e481
fixes typo
markconroy 5149888
Merge pull request #595 from localgovdrupal/312-add-back-to-top-button
markconroy e6c8082
Merge pull request #594 from localgovdrupal/427/fix/stop-jaws-reading…
markconroy 7238b24
feat: add expand/collapse icon to accordion
millnut 8762135
feat: add expand/collapse icon to accordion
millnut bd084bf
fix: set color on service status heading
millnut a38be8c
hides guides/steps navigation in print mode
markconroy d33856e
adds CSS for blockquotes created via WYSIWYG
markconroy 2b5da22
ensures quick fact content is inside a <p> tag
markconroy b2a1254
uses variable for accordion icon
markconroy dd2572f
adds more space for clickable area for pager items
markconroy 928c53e
formatting code
markconroy 1c66e02
adds alt text for map opening in new tab
markconroy a1362aa
Merge pull request #617 from localgovdrupal/fix/607/quick-fact-semantics
ekes 2028da7
Merge pull request #616 from localgovdrupal/fix/611/blockquote-wysiwyg
ekes 3833ab0
Merge pull request #615 from localgovdrupal/feature/614/hide-guides-s…
ekes 66ec604
Merge pull request #603 from localgovdrupal/feature/1.x/add-expand-co…
ekes 671d694
Merge pull request #619 from localgovdrupal/fix/618/page-target-area
ekes 19a463a
Merge pull request #604 from localgovdrupal/fix/1.x/set-color-on-serv…
ekes 77a749e
sticky header settings for localgov_base (#569)
markconroy aa313c9
Merge pull request #620 from localgovdrupal/fix/612/alt-text-service-…
markconroy d563ab4
Fixes #366 - text overlapping Guide Nav (#625)
mccrodp 7ffc23a
Fix config schema error #629 (#630)
stephen-cox ae91066
removes localgov_base_helper module (#632)
markconroy 0e70057
Adds support for facet forms (#634)
markconroy 6b5cac7
Adds empty breadcrumbs block for use by microsites_base (#636)
markconroy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
.sticky-header--sticky .lgd-header { | ||
top: var(--lgd-sticky-header-position); | ||
width: 100%; | ||
z-index: 1000; | ||
} | ||
|
||
.sticky-header--sticky .lgd-header + * { | ||
margin-top: calc(var(--lgd-sticky-header-position) + var(--lgd-sticky-header-height)); | ||
scroll-padding: var(--lgd-sticky-header-height); | ||
} | ||
|
||
.sticky-header-html, | ||
.sticky-header--sticky { | ||
scroll-padding-top: var(--lgd-sticky-header-height); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
(function stickyHeaderScript(Drupal) { | ||
Drupal.behaviors.stickyHeader = { | ||
attach: function (context) { | ||
const headers = once('allSticyHeaders', '.lgd-header', context); | ||
|
||
if (!headers) { | ||
return; | ||
} | ||
|
||
headers.forEach(header => { | ||
function calculatePositions() { | ||
let tabsHeight = 0; | ||
const tabs = header.closest('body').querySelector('.lgd-region--tabs'); | ||
if (tabs) { | ||
tabsHeight = tabs.offsetHeight; | ||
} | ||
|
||
let displaceOffsetTop = 0; | ||
const displaceOffsetTopValue = parseInt(getComputedStyle(document.documentElement).getPropertyValue('--drupal-displace-offset-top').replace('px', '')); | ||
if (displaceOffsetTopValue) { | ||
displaceOffsetTop = displaceOffsetTopValue; | ||
} | ||
|
||
const headerHeight = header.offsetHeight; | ||
const headerPosition = displaceOffsetTop + tabsHeight; | ||
|
||
if (header.closest('body').classList.contains('sticky-header')) { | ||
document.documentElement.style.setProperty('--lgd-sticky-header-position', `${headerPosition}px`); | ||
document.documentElement.style.setProperty('--lgd-sticky-header-height', `${headerHeight}px`); | ||
} | ||
|
||
if (header.closest('body').classList.contains('sticky-header--sticky')) { | ||
header.style.position = 'fixed'; | ||
} | ||
} | ||
|
||
// Initialize oldScroll, so we can use it in the scroll event. | ||
let oldScroll = window.scrollY; | ||
|
||
function handleScroll() { | ||
if (oldScroll > window.scrollY) { | ||
header.closest('body').classList.add('sticky-header--sticky'); | ||
} else { | ||
header.closest('body').classList.remove('sticky-header--sticky'); | ||
header.style.position = 'relative'; | ||
} | ||
// Update oldScroll to the new scroll position after the comparison | ||
oldScroll = window.scrollY; | ||
|
||
calculatePositions(); | ||
} | ||
|
||
if (header.closest('body').classList.contains('sticky-header--scroll')) { | ||
window.addEventListener('scroll', handleScroll); | ||
} | ||
|
||
setTimeout(() => { | ||
calculatePositions(); | ||
}, 50); | ||
|
||
}); | ||
|
||
} | ||
}; | ||
})(Drupal); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
## INTRODUCTION | ||
|
||
The LocalGov Base Helper module is a module to allow us to add update hooks and other module functionality to LocalGov Base. | ||
|
||
## INSTALLATION | ||
|
||
Install as you would normally install a contributed Drupal module. | ||
See: https://www.drupal.org/node/895232 for further information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
name: 'LocalGov Base Helper' | ||
type: module | ||
description: 'Adds update hooks to LocalGov Base.' | ||
package: LocalGov Drupal | ||
core_version_requirement: ^10 || ^11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
<?php | ||
|
||
/** | ||
* @file | ||
* Install, update and uninstall functions for LocalGov Base Helper. | ||
*/ | ||
|
||
/** | ||
* Implements hook_install(). | ||
*/ | ||
function localgov_base_helper_install() { | ||
$theme_handler = \Drupal::service('theme_handler'); | ||
// Check if the 'localgov_base' theme is available. | ||
if ($theme_handler->themeExists('localgov_base')) { | ||
// Now, check if it is enabled. | ||
// If not yet enabled, these settings will be taken from the theme's | ||
// /config/install directory, instead of here. | ||
$theme = $theme_handler->getTheme('localgov_base'); | ||
if ($theme->status) { | ||
// The theme is installed and enabled, proceed to set the config. | ||
$config = \Drupal::configFactory()->getEditable('theme.localgov_base.settings'); | ||
if ($config->get('localgov_base_header_behaviour') === NULL) { | ||
$config->set('localgov_base_header_behaviour', 'default'); | ||
} | ||
$config->save(); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
<?php | ||
|
||
/** | ||
* @file | ||
* Primary module hooks for LocalGov Base Helper module. | ||
*/ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.