Skip to content

Call the "onToolCallRequestFailure" callback if the model is generating a tool call + the generation failed. #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ryan-the-crayon
Copy link
Collaborator

This makes sure that there will also be a matching onToolCallRequestEnd or onToolCallRequestFailure for each onToolCallRequestStart, even in the case of failure. Thus those hooks alone are enough to synchronize UI.

@ryan-the-crayon ryan-the-crayon requested review from yagil and azisislm May 22, 2025 17:08
@github-actions github-actions bot added the CLA signed Indicates if all contributors have signed the CLA label May 22, 2025
@ryan-the-crayon ryan-the-crayon merged commit 2a80734 into main May 22, 2025
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA signed Indicates if all contributors have signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants