Use ceilMode from pytorch MaxPool in shlo to get correct output shape #4167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pytorch passes an argument
ceilMode
into MaxPool op.Currently, torch to stablehlo conversion does not use it to determine stablehlo output shape.
This change intends to use the same logic as torch to use ceilMode when calculating output shape.
During conversion, we make up the size difference using padding.
Changes:
ceilMode
param the way torch uses it.