Add DebugifyBuilder for debug location coverage testing #493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new build factory for running tests using Debugify, for the purposes of detecting debug info errors as proposed on Discourse. This builder is very similar to the
TestSuiteBuilder, but it adds some required CMake flags to the LLVM and Test Suite builds, and adds an extra step where we use a script withinllvm/utilsto evaluate the output of Debugify.As part of implementing this, I had to make some small changes to the
TestSuiteBuilderto allow CMake flags to be passed for the Test Suite build, as currently it only accepts flags for the LLVM build. These changes should be a no-op for all existing builds; only by passing the newextra_test_suite_configure_argsparameter should this have any effect.