-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Reapply [mlir][vector] Refactor WarpOpScfForOp to support unused or swapped forOp results. #148313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
charithaintc
wants to merge
17
commits into
llvm:main
Choose a base branch
from
charithaintc:reapply_scf_for_distr_bug_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Reapply [mlir][vector] Refactor WarpOpScfForOp to support unused or swapped forOp results. #148313
charithaintc
wants to merge
17
commits into
llvm:main
from
charithaintc:reapply_scf_for_distr_bug_fix
+265
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, @kurapov-peter, @Jianhui-Li Can you please review the diff here. |
kurapov-peter
approved these changes
Jul 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd cover all the indexing logic with assertions, pretty brittle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply attempt for : #148291
Fix for the build failure reported in : https://lab.llvm.org/buildbot/#/builders/116/builds/15477
This crash is caused by mismatch of distributed type returned by
getDistributedType
and intended distributed type for forOp results.Solution diff: 20c2cf6
Example:
In this case the distributed type for forOp result is
vector<1xf32>
(result is not distributed and broadcasted to all lanes instead). However, in this casegetDistributedType
will return NULL type.Therefore, if the distributed type can be recovered from warpOp, we should always do that first before using
getDistributedType