[LLDB] Use non synthetic value for MSVC smart ptr check

[Nerixyz]

I forgot to use the non-synthetic value to check for the _Ptr member.

Fixes the test failure from #147575.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: nerix (Nerixyz)

Changes

I forgot to use the non-synthetic value to check for the _Ptr member.

Fixes the test failure from #147575.

---

Full diff: https://github.com/llvm/llvm-project/pull/148176.diff

1 Files Affected:

• (modified) lldb/source/Plugins/Language/CPlusPlus/MsvcStlSmartPointer.cpp (+2-1)

diff --git a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlSmartPointer.cpp b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlSmartPointer.cpp
index 4a51879863f17..b5a85ab5deb8b 100644
--- a/lldb/source/Plugins/Language/CPlusPlus/MsvcStlSmartPointer.cpp
+++ b/lldb/source/Plugins/Language/CPlusPlus/MsvcStlSmartPointer.cpp
@@ -15,7 +15,8 @@
 using namespace lldb;
 
 bool lldb_private::formatters::IsMsvcStlSmartPointer(ValueObject &valobj) {
-  return valobj.GetChildMemberWithName("_Ptr") != nullptr;
+  ValueObjectSP valobj_sp = valobj.GetNonSyntheticValue();
+  return valobj_sp->GetChildMemberWithName("_Ptr") != nullptr;
 }
 
 bool lldb_private::formatters::MsvcStlSmartPointerSummaryProvider(

[Nerixyz]

@Michael137 Sorry for the failure, I only built LLDB before but didn't run the tests after fixing the suggestions 🤦

[Michael137]

no worries!
LGTM

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[Nerixyz]

Windows premerge checks would be great for this. I opened #146236, but there are still some LLDB tests failing. Not really sure why.

[Michael137]

Windows premerge checks would be great for this. I opened #146236, but there are still some LLDB tests failing. Not really sure why.

That's awesome! I think @Endilll looked at Windows pre-merge testing in the past (at least for Clang, but IIRC maybe also LLDB?), but it was disabled due to bandwidth issues. I'll CC him on #146236