[MLIR][Conversion] Add convert-xevm-to-llvm pass. [Re-attempt] #148103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Artem Kroviakov artem.kroviakov@intel.com
…values [-Wcovered-switch-default]
|
@charithaintc @mshahneo Co-authored-by: Artem Kroviakov artem.kroviakov@intel.com |
Comment on lines
+547
to
+552
| std::string prefetchCode(""); | ||
| if (!isPrefetch) | ||
| prefetchCode += "P"; | ||
| funcName = llvm::formatv("_Z{0}{1}PU3AS1viiiDv2_i{2}{3}", funcName.size(), | ||
| funcName, prefetchCode, bitWidthId) | ||
| .str(); |
There was a problem hiding this comment.
is this the only diff?
There was a problem hiding this comment.
Yes. The new PR is on the same branch. With only one new commit.
charithaintc
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #147375 failed a couple of builds after merging.
Compile error was reported with gcc 7.5
This PR is #147375 plus the fix for compile error with gcc 7.5