[IR2Vec] Add embeddings mode to llvm-ir2vec tool #147844
Open
+248
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2025
svkeerthy
changed the title
svkeerthy
requested review from
boomanaiden154,
kazutakahirata,
mtrofin and
snehasish
| @@ -0,0 +1,73 @@ | |||
| ; RUN: llvm-ir2vec --mode=embeddings --ir2vec-vocab-path=%S/../../Analysis/IR2Vec/Inputs/dummy_3D_nonzero_opc_vocab.json %s | FileCheck %s -check-prefix=CHECK-DEFAULT | |||
There was a problem hiding this comment.
Given you access %S../../Analysis/IR2Vec/Inputs so often, I'm wondering if it makes sense to add a lit substitution. Maybe something like %ir2vec_test_vocab or something.
| namespace { | ||
|
|
||
| /// Helper class for collecting IR information and generating triplets | ||
| /// Helper class for collecting IR information and generating embeddings |
There was a problem hiding this comment.
This comment seems incorrect given this can do embeddings and triplets?
There was a problem hiding this comment.
Thanks for the catch. Will fix it.
| } | ||
| } | ||
|
|
||
| // OS << "\n"; |
| "--level=func (functions)\n"); | ||
|
|
||
| // Validate command line options | ||
| if (Mode == TripletMode && Level != FunctionLevel) { |
There was a problem hiding this comment.
This might be a bit confusing if the user explicitly requests function level triplet mode. I think there's a way to see if the user has actually passed a flag with cl::opt, but I'm not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add embedding generation functionality to the llvm-ir2vec tool, complementing the existing triplet generation mode.
This change completes the IR2Vec tool by adding the embedding generation functionality, which was previously mentioned as a TODO item. The tool now supports both triplet generation for vocabulary training and embedding generation using a trained vocabulary.