Skip to content

[flang] Don't check the '-mframe-pointer' flag #147837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dpaoliello
Copy link
Contributor

The -mframe-pointer flag is not explicitly set in the original flang invocation and so the value passed to flang -fc1 can vary depending on the host machine, so don't verify it in the output.

-mframe-pointer forwarding is already verified by flang/test/Driver/frame-pointer-forwarding.f90.

@llvmbot llvmbot added flang:driver flang Flang issues not falling into any other category labels Jul 9, 2025
@llvmbot
Copy link
Member

llvmbot commented Jul 9, 2025

@llvm/pr-subscribers-flang-driver

Author: Daniel Paoliello (dpaoliello)

Changes

The -mframe-pointer flag is not explicitly set in the original flang invocation and so the value passed to flang -fc1 can vary depending on the host machine, so don't verify it in the output.

-mframe-pointer forwarding is already verified by flang/test/Driver/frame-pointer-forwarding.f90.


Full diff: https://github.com/llvm/llvm-project/pull/147837.diff

1 Files Affected:

  • (modified) flang/test/Driver/frontend-forwarding.f90 (-1)
diff --git a/flang/test/Driver/frontend-forwarding.f90 b/flang/test/Driver/frontend-forwarding.f90
index 55a74ccf40467..952937168c95d 100644
--- a/flang/test/Driver/frontend-forwarding.f90
+++ b/flang/test/Driver/frontend-forwarding.f90
@@ -60,7 +60,6 @@
 ! CHECK: "-Reverything"
 ! CHECK: "-Rno-everything"
 ! CHECK: "-Rpass=inline"
-! CHECK: "-mframe-pointer=none"
 ! CHECK: "-mllvm" "-print-before-all"
 ! CHECK: "-fwrapv"
 ! CHECK: "-save-temps=obj"

@dpaoliello dpaoliello requested review from DavidTruby and klausler July 9, 2025 22:28
@klausler klausler removed their request for review July 9, 2025 22:29
Copy link
Contributor

@pawosm-arm pawosm-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this is already being checked by flang/test/Driver/frame-pointer-forwarding.f90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:driver flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants