[SelectionDAG] fold (not (sub Y, X)) -> (add X, ~Y)

[AZero13]

This replaces (not (neg x)) -> (add X, -1) because that is covered by this.

[llvmbot]

@llvm/pr-subscribers-backend-x86
@llvm/pr-subscribers-backend-powerpc

@llvm/pr-subscribers-llvm-selectiondag

Author: AZero13 (AZero13)

Changes

This replaces (not (neg x)) -> (add X, -1) because that is covered by this.

---

Full diff: https://github.com/llvm/llvm-project/pull/147825.diff

1 Files Affected:

• (modified) llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (+7-7)

diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
index 9ffdda28f7899..90c673dd7e83b 100644
--- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -9979,13 +9979,13 @@ SDValue DAGCombiner::visitXOR(SDNode *N) {
     }
   }
 
-  // fold (not (neg x)) -> (add X, -1)
-  // FIXME: This can be generalized to (not (sub Y, X)) -> (add X, ~Y) if
-  // Y is a constant or the subtract has a single use.
-  if (isAllOnesConstant(N1) && N0.getOpcode() == ISD::SUB &&
-      isNullConstant(N0.getOperand(0))) {
-    return DAG.getNode(ISD::ADD, DL, VT, N0.getOperand(1),
-                       DAG.getAllOnesConstant(DL, VT));
+  // fold (not (sub Y, X)) -> (add X, ~Y) is subtract is a single use
+  // or Y is a constant.
+  if (isAllOnesOrAllOnesSplat(N1) && N0.getOpcode() == ISD::SUB) {
+    ConstantSDNode *Const = dyn_cast<ConstantSDNode>(N0.getOperand(0));
+    if (Const || N0.hasOneUse())
+      return DAG.getNode(ISD::ADD, DL, VT, N0.getOperand(1),
+                         DAG.getNOT(DL, N0.getOperand(0), VT));
   }
 
   // fold (not (add X, -1)) -> (neg X)

[badumbatish]

has there been a test for this selectiondag folding after & before the TODO? it would be beneficial to add one if not

[arsenm]

Missing tests. Please never post functional change patches without tests

[arsenm]

Suggested change

	if (isAllOnesConstant(N1) && N0.getOpcode() == ISD::SUB) {
	if (N0.getOpcode() == ISD::SUB && isAllOnesConstant(N1)) {

[topperc]

Stop force pushing patches. I'm tired of repeating this.