Skip to content

[flang] Extension: TRANSFER(boz, integer or real scalar) #147604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+42 −1
Open

[flang] Extension: TRANSFER(boz, integer or real scalar) #147604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions flang/docs/Extensions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,8 @@ end
the type resolution of such BOZ literals usages is highly non portable).
* BOZ literals can also be used as REAL values in some contexts where the
type is unambiguous, such as initializations of REAL parameters.
* `TRANSFER(boz, MOLD=integer or real scalar)` is accepted as an alternate
spelling of `INT(boz, KIND=kind(mold))` or `REAL(boz, KIND=kind(mold))`.
* EQUIVALENCE of numeric and character sequences (a ubiquitous extension),
as well as of sequences of non-default kinds of numeric types
with each other.
Expand Down
2 changes: 1 addition & 1 deletion flang/include/flang/Support/Fortran-features.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ ENUM_CLASS(LanguageFeature, BackslashEscapes, OldDebugLines,
SavedLocalInSpecExpr, PrintNamelist, AssumedRankPassedToNonAssumedRank,
IgnoreIrrelevantAttributes, Unsigned, AmbiguousStructureConstructor,
ContiguousOkForSeqAssociation, ForwardRefExplicitTypeDummy,
InaccessibleDeferredOverride, CudaWarpMatchFunction)
InaccessibleDeferredOverride, CudaWarpMatchFunction, TransferBOZ)

// Portability and suspicious usage warnings
ENUM_CLASS(UsageWarning, Portability, PointerToUndefinable,
Expand Down
10 changes: 10 additions & 0 deletions flang/lib/Evaluate/fold.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,16 @@ std::optional<Expr<SomeType>> FoldTransfer(
CHECK(status == InitialImage::NotAConstant);
}
}
} else if (source && moldType) {
if (const auto *boz{std::get_if<BOZLiteralConstant>(&source->u)}) {
// TRANSFER(BOZ, MOLD=integer or real) extension
if (context.languageFeatures().ShouldWarn(
common::LanguageFeature::TransferBOZ)) {
context.messages().Say(common::LanguageFeature::TransferBOZ,
"TRANSFER(BOZ literal) is not standard"_port_en_US);
}
return Fold(context, ConvertToType(*moldType, Expr<SomeType>{*boz}));
}
}
return std::nullopt;
}
Expand Down
9 changes: 9 additions & 0 deletions flang/lib/Evaluate/intrinsics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,6 +1015,15 @@ static const IntrinsicInterface genericIntrinsicFunction[]{
{"mold", SameType, Rank::anyOrAssumedRank},
{"size", AnyInt, Rank::scalar}},
SameType, Rank::vector, IntrinsicClass::transformationalFunction},
// TRANSFER(BOZ, MOLD=integer or real scalar) extension
{"transfer",
{{"source", AnyNumeric, Rank::elementalOrBOZ},
{"mold", SameInt, Rank::scalar}},
SameInt, Rank::scalar, IntrinsicClass::transformationalFunction},
{"transfer",
{{"source", AnyNumeric, Rank::elementalOrBOZ},
{"mold", SameReal, Rank::scalar}},
SameReal, Rank::scalar, IntrinsicClass::transformationalFunction},
{"transpose", {{"matrix", SameType, Rank::matrix}}, SameType, Rank::matrix,
IntrinsicClass::transformationalFunction},
{"trim", {{"string", SameCharNoLen, Rank::scalar}}, SameCharNoLen,
Expand Down
1 change: 1 addition & 0 deletions flang/lib/Support/Fortran-features.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ LanguageFeatureControl::LanguageFeatureControl() {
warnLanguage_.set(LanguageFeature::ListDirectedSize);
warnLanguage_.set(LanguageFeature::IgnoreIrrelevantAttributes);
warnLanguage_.set(LanguageFeature::AmbiguousStructureConstructor);
warnLanguage_.set(LanguageFeature::TransferBOZ);
warnUsage_.set(UsageWarning::ShortArrayActual);
warnUsage_.set(UsageWarning::FoldingException);
warnUsage_.set(UsageWarning::FoldingAvoidsRuntimeCrash);
Expand Down
19 changes: 19 additions & 0 deletions flang/test/Evaluate/transfer-boz.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
!RUN: %flang_fc1 -fdebug-unparse %s | FileCheck %s

!CHECK: portability: TRANSFER(BOZ literal) is not standard [-Wtransfer-boz]
!CHECK: portability: TRANSFER(BOZ literal) is not standard [-Wtransfer-boz]
!CHECK: portability: TRANSFER(BOZ literal) is not standard [-Wtransfer-boz]
!CHECK: portability: TRANSFER(BOZ literal) is not standard [-Wtransfer-boz]
!CHECK: portability: TRANSFER(BOZ literal) is not standard [-Wtransfer-boz]
!CHECK: PRINT *, -17_1
!CHECK: PRINT *, -16657_2
!CHECK: PRINT *, -559038737_4
!CHECK: PRINT *, -6.259853398707798016e18_4
!CHECK: PRINT *, 1.8457939563190925445492984919045437485528002903297587499184927815557801644025850059853181797614625558939883606558067941052215743386077465406508281130260792904117042434297523782789810991060595088402505831985608687099349932384478542748214418349497866218005870896526832696740683567118136284392505567470522678176873737470272665943917715636680452977840047387616237048162886116765806372690690621665407240253312632381089695794498069551496558727944808752442655077077609749137334421734380446229972733723471196114034171513283476953482396960122117078210644171413215132537631249069125441199719426016512325803207900875869312966829207468856964517085119314095898691593840972164432952065765882286023532502465793032567186884340163939544586513274992967126308940351009368896484375e-314_8
Comment on lines +11 to +12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's going through the same flang-rt implemented in the same way on all platforms, the floating point values are going to display exactly the same on all platforms, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not using flang_rt, but instead the Decimal package that's part of both the compiler and the runtime. And it has no host hardware dependence.


print *, transfer(z'deadbeef', 1_1)
print *, transfer(z'deadbeef', 1_2)
print *, transfer(z'deadbeef', 1_4)
print *, transfer(z'deadbeef', 1._4)
print *, transfer(z'deadbeef', 1._8)
end