Skip to content

premerge: Enable on Linux and Windows #147581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: release/20.x
Choose a base branch
from

Conversation

tstellar
Copy link
Collaborator

@tstellar tstellar commented Jul 8, 2025

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Jul 8, 2025

@llvm/pr-subscribers-github-workflow

Author: Tom Stellard (tstellar)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/147581.diff

1 Files Affected:

  • (modified) .github/workflows/premerge.yaml (+2-2)
diff --git a/.github/workflows/premerge.yaml b/.github/workflows/premerge.yaml
index 9b6a1236823d7..f93e3bdedbaa2 100644
--- a/.github/workflows/premerge.yaml
+++ b/.github/workflows/premerge.yaml
@@ -26,7 +26,7 @@ concurrency:
 jobs:
   premerge-checks-linux:
     if: >-
-        false && github.repository_owner == 'llvm' &&
+        github.repository_owner == 'llvm' &&
         (github.event_name != 'pull_request' || github.event.action != 'closed')
     runs-on: llvm-premerge-linux-runners
     steps:
@@ -84,7 +84,7 @@ jobs:
 
   premerge-checks-windows:
     if: >-
-        false && github.repository_owner == 'llvm' &&
+        github.repository_owner == 'llvm' &&
         (github.event_name != 'pull_request' || github.event.action != 'closed')
     runs-on: llvm-premerge-windows-runners
     defaults:

@tstellar tstellar requested a review from boomanaiden154 July 8, 2025 18:12
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it was supposed to be Enable on Linux and Windows?

@tstellar tstellar changed the title premerge: Enable on Linux on Windows premerge: Enable on Linux and Windows Jul 8, 2025
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM barring removing the test trigger from llvm/README.txt. Given that we're now planning on using this in the release branch too, do you want all changes going into premerge.yaml to also be backported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants