[llvm] statically link TableGenTests #147577
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@compnerd @vgvassilev here's another quick one, thanks! |
compnerd
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Statically link
TableGenTestsso it can still build when linked against an LLVM Windows DLL.Background
The effort to build LLVM as a WIndows DLL is tracked in #109483. Additional context is provided in this discourse.
If
TableGenTestsis linked against LLVM built as a DLL on Windows, it will fail due to a large number of duplicate symbols found in both the LLVM DLL and TableGen libraries. This is becauseLLVMTableGenBasicandLLVMTableGenCommonare linked statically against LLVM (usingDISABLE_LLVM_LINK_LLVM_DYLIB) so already contain a sub-set of symbols also exported from the LLVM DLL.This patch was originally part of #145448.