[DirectX] Validate if Textures/TypedBuffers are being bound in Root Signatures #147573

joaosaffran · 2025-07-08T17:12:30Z

DXC doesn't allow Textures/TypedBuffers to bind with root signature descriptors, this implements the same check.

…/textures-not-bind-root-signatures

llvmbot · 2025-07-08T17:13:03Z

@llvm/pr-subscribers-hlsl

Author: None (joaosaffran)

Changes

DXC doesn't allow Textures/TypedBuffers to bind with root signature descriptors, this implements the same check in clang.

Closes: #126647

Full diff: https://github.com/llvm/llvm-project/pull/147573.diff

2 Files Affected:

(added) clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl (+13)
(modified) llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp (+25)

diff --git a/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl b/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl
new file mode 100644
index 0000000000000..9daf38e30dd67
--- /dev/null
+++ b/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl
@@ -0,0 +1,13 @@
+// RUN: not %clang_dxc -T cs_6_6 -E CSMain %s 2>&1 | FileCheck %s
+
+// CHECK: error: register srv (space=0, register=0) is bound to a texture or typed buffer.
+
+RWStructuredBuffer<int> Out : register(u0);
+Buffer<float> B : register(t0);
+// Compute Shader for UAV testing
+[numthreads(8, 8, 1)]
+[RootSignature("SRV(t0), UAV(u0)")]
+void CSMain(uint id : SV_GroupID)
+{
+    Out[0] = B[0];
+}
diff --git a/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp b/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
index a52a04323514c..c34f31fbe35e5 100644
--- a/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
+++ b/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
@@ -85,6 +85,17 @@ static void reportOverlappingBinding(Module &M, DXILResourceMap &DRM) {
   }
 }
 
+static void
+reportInvalidHandleTyBoundInRs(Module &M, Twine Type,
+                               ResourceInfo::ResourceBinding Binding) {
+  SmallString<128> Message;
+  raw_svector_ostream OS(Message);
+  OS << "register " << Type << " (space=" << Binding.Space
+     << ", register=" << Binding.LowerBound << ")"
+     << " is bound to a texture or typed buffer.";
+  M.getContext().diagnose(DiagnosticInfoGeneric(Message));
+}
+
 static void reportRegNotBound(Module &M, Twine Type,
                               ResourceInfo::ResourceBinding Binding) {
   SmallString<128> Message;
@@ -163,12 +174,26 @@ static void reportErrors(Module &M, DXILResourceMap &DRM,
       ResourceInfo::ResourceBinding Binding = SRV.getBinding();
       if (!Validation.checkTRegBinding(Binding))
         reportRegNotBound(M, "srv", Binding);
+      else {
+        const auto *Handle =
+            dyn_cast_or_null<RawBufferExtType>(SRV.getHandleTy());
+
+        if (!Handle)
+          reportInvalidHandleTyBoundInRs(M, "srv", Binding);
+      }
     }
 
     for (const ResourceInfo &UAV : DRM.uavs()) {
       ResourceInfo::ResourceBinding Binding = UAV.getBinding();
       if (!Validation.checkURegBinding(Binding))
         reportRegNotBound(M, "uav", Binding);
+      else {
+        const auto *Handle =
+            dyn_cast_or_null<RawBufferExtType>(UAV.getHandleTy());
+
+        if (!Handle)
+          reportInvalidHandleTyBoundInRs(M, "srv", Binding);
+      }
     }
 
     for (const ResourceInfo &Sampler : DRM.samplers()) {

llvmbot · 2025-07-08T17:13:04Z

@llvm/pr-subscribers-backend-directx

Author: None (joaosaffran)

Changes

DXC doesn't allow Textures/TypedBuffers to bind with root signature descriptors, this implements the same check in clang.

Closes: #126647

Full diff: https://github.com/llvm/llvm-project/pull/147573.diff

2 Files Affected:

(added) clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl (+13)
(modified) llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp (+25)

diff --git a/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl b/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl
new file mode 100644
index 0000000000000..9daf38e30dd67
--- /dev/null
+++ b/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl
@@ -0,0 +1,13 @@
+// RUN: not %clang_dxc -T cs_6_6 -E CSMain %s 2>&1 | FileCheck %s
+
+// CHECK: error: register srv (space=0, register=0) is bound to a texture or typed buffer.
+
+RWStructuredBuffer<int> Out : register(u0);
+Buffer<float> B : register(t0);
+// Compute Shader for UAV testing
+[numthreads(8, 8, 1)]
+[RootSignature("SRV(t0), UAV(u0)")]
+void CSMain(uint id : SV_GroupID)
+{
+    Out[0] = B[0];
+}
diff --git a/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp b/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
index a52a04323514c..c34f31fbe35e5 100644
--- a/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
+++ b/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
@@ -85,6 +85,17 @@ static void reportOverlappingBinding(Module &M, DXILResourceMap &DRM) {
   }
 }
 
+static void
+reportInvalidHandleTyBoundInRs(Module &M, Twine Type,
+                               ResourceInfo::ResourceBinding Binding) {
+  SmallString<128> Message;
+  raw_svector_ostream OS(Message);
+  OS << "register " << Type << " (space=" << Binding.Space
+     << ", register=" << Binding.LowerBound << ")"
+     << " is bound to a texture or typed buffer.";
+  M.getContext().diagnose(DiagnosticInfoGeneric(Message));
+}
+
 static void reportRegNotBound(Module &M, Twine Type,
                               ResourceInfo::ResourceBinding Binding) {
   SmallString<128> Message;
@@ -163,12 +174,26 @@ static void reportErrors(Module &M, DXILResourceMap &DRM,
       ResourceInfo::ResourceBinding Binding = SRV.getBinding();
       if (!Validation.checkTRegBinding(Binding))
         reportRegNotBound(M, "srv", Binding);
+      else {
+        const auto *Handle =
+            dyn_cast_or_null<RawBufferExtType>(SRV.getHandleTy());
+
+        if (!Handle)
+          reportInvalidHandleTyBoundInRs(M, "srv", Binding);
+      }
     }
 
     for (const ResourceInfo &UAV : DRM.uavs()) {
       ResourceInfo::ResourceBinding Binding = UAV.getBinding();
       if (!Validation.checkURegBinding(Binding))
         reportRegNotBound(M, "uav", Binding);
+      else {
+        const auto *Handle =
+            dyn_cast_or_null<RawBufferExtType>(UAV.getHandleTy());
+
+        if (!Handle)
+          reportInvalidHandleTyBoundInRs(M, "srv", Binding);
+      }
     }
 
     for (const ResourceInfo &Sampler : DRM.samplers()) {

llvmbot · 2025-07-08T17:13:04Z

@llvm/pr-subscribers-clang

Author: None (joaosaffran)

Changes

DXC doesn't allow Textures/TypedBuffers to bind with root signature descriptors, this implements the same check in clang.

Closes: #126647

Full diff: https://github.com/llvm/llvm-project/pull/147573.diff

2 Files Affected:

(added) clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl (+13)
(modified) llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp (+25)

diff --git a/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl b/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl
new file mode 100644
index 0000000000000..9daf38e30dd67
--- /dev/null
+++ b/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl
@@ -0,0 +1,13 @@
+// RUN: not %clang_dxc -T cs_6_6 -E CSMain %s 2>&1 | FileCheck %s
+
+// CHECK: error: register srv (space=0, register=0) is bound to a texture or typed buffer.
+
+RWStructuredBuffer<int> Out : register(u0);
+Buffer<float> B : register(t0);
+// Compute Shader for UAV testing
+[numthreads(8, 8, 1)]
+[RootSignature("SRV(t0), UAV(u0)")]
+void CSMain(uint id : SV_GroupID)
+{
+    Out[0] = B[0];
+}
diff --git a/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp b/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
index a52a04323514c..c34f31fbe35e5 100644
--- a/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
+++ b/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
@@ -85,6 +85,17 @@ static void reportOverlappingBinding(Module &M, DXILResourceMap &DRM) {
   }
 }
 
+static void
+reportInvalidHandleTyBoundInRs(Module &M, Twine Type,
+                               ResourceInfo::ResourceBinding Binding) {
+  SmallString<128> Message;
+  raw_svector_ostream OS(Message);
+  OS << "register " << Type << " (space=" << Binding.Space
+     << ", register=" << Binding.LowerBound << ")"
+     << " is bound to a texture or typed buffer.";
+  M.getContext().diagnose(DiagnosticInfoGeneric(Message));
+}
+
 static void reportRegNotBound(Module &M, Twine Type,
                               ResourceInfo::ResourceBinding Binding) {
   SmallString<128> Message;
@@ -163,12 +174,26 @@ static void reportErrors(Module &M, DXILResourceMap &DRM,
       ResourceInfo::ResourceBinding Binding = SRV.getBinding();
       if (!Validation.checkTRegBinding(Binding))
         reportRegNotBound(M, "srv", Binding);
+      else {
+        const auto *Handle =
+            dyn_cast_or_null<RawBufferExtType>(SRV.getHandleTy());
+
+        if (!Handle)
+          reportInvalidHandleTyBoundInRs(M, "srv", Binding);
+      }
     }
 
     for (const ResourceInfo &UAV : DRM.uavs()) {
       ResourceInfo::ResourceBinding Binding = UAV.getBinding();
       if (!Validation.checkURegBinding(Binding))
         reportRegNotBound(M, "uav", Binding);
+      else {
+        const auto *Handle =
+            dyn_cast_or_null<RawBufferExtType>(UAV.getHandleTy());
+
+        if (!Handle)
+          reportInvalidHandleTyBoundInRs(M, "srv", Binding);
+      }
     }
 
     for (const ResourceInfo &Sampler : DRM.samplers()) {

bogner

this implements the same check in clang.

This isn't a check "in clang" - that implies that this is a frontend check, but the logic here is fully in the backend. That said - does this need to be done post optimizations? Couldn't a frontend check catch this reliably?

bogner · 2025-07-08T17:40:49Z

clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl

This isn't the right place for this test - we can't have clang tests for llvm backend behaviour. We'll need something in llvm/test/CodeGen/DirectX instead.

…idation/check-descriptors-are-bound

…/textures-not-bind-root-signatures

joaosaffran added 4 commits July 7, 2025 19:26

add validation

01a558b

adding validation

43eb04e

Merge branch 'validation/check-descriptors-are-bound' into validation…

f67bec1

…/textures-not-bind-root-signatures

format

d7b4cf4

llvmbot added clang Clang issues not falling into any other category backend:DirectX HLSL HLSL Language Support labels Jul 8, 2025

format

c7d5be7

joaosaffran changed the title ~~[DirectX] Validate if Textures/TypedBuffers are being bind in Root Signatures~~ [DirectX] Validate if Textures/TypedBuffers are being bound in Root Signatures Jul 8, 2025

bogner requested changes Jul 8, 2025

View reviewed changes

joaosaffran added 4 commits July 8, 2025 19:02

address changes

cc5afae

Merge branch 'refactoring/updating-return-root-sig-analysis' into val…

974d4bc

…idation/check-descriptors-are-bound

Merge branch 'validation/check-descriptors-are-bound' into validation…

403b546

…/textures-not-bind-root-signatures

fix test

aea75da

joaosaffran requested a review from bogner July 8, 2025 20:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DirectX] Validate if Textures/TypedBuffers are being bound in Root Signatures #147573

[DirectX] Validate if Textures/TypedBuffers are being bound in Root Signatures #147573

Uh oh!

joaosaffran commented Jul 8, 2025 •

edited

Loading

Uh oh!

llvmbot commented Jul 8, 2025

Uh oh!

llvmbot commented Jul 8, 2025

Uh oh!

llvmbot commented Jul 8, 2025

Uh oh!

bogner left a comment

Uh oh!

bogner Jul 8, 2025 •

edited

Loading

Uh oh!

Uh oh!

[DirectX] Validate if Textures/TypedBuffers are being bound in Root Signatures #147573

Are you sure you want to change the base?

[DirectX] Validate if Textures/TypedBuffers are being bound in Root Signatures #147573

Uh oh!

Conversation

joaosaffran commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Jul 8, 2025

Uh oh!

llvmbot commented Jul 8, 2025

Uh oh!

llvmbot commented Jul 8, 2025

Uh oh!

bogner left a comment

Choose a reason for hiding this comment

Uh oh!

bogner Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joaosaffran commented Jul 8, 2025 •

edited

Loading

bogner Jul 8, 2025 •

edited

Loading