Skip to content

RuntimeLibcalls: Fix dropping first libcall entry #147461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lld/test/wasm/lto/Inputs/libcall-archive.ll
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,12 @@ define void @memcpy() #0 {
ret void
}

define float @acosf(float %x) {
ret float %x
}

define i128 @__umodti3(i128 %a, i128 %b) {
ret i128 %a
}

attributes #0 = { "target-features"="-bulk-memory,-bulk-memory-opt" }
26 changes: 24 additions & 2 deletions lld/test/wasm/lto/libcall-archive.ll
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,28 @@
target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-n32:64-S128-ni:1:10:20"
target triple = "wasm32-unknown-unknown"

@llvm.used = appending global [2 x ptr] [ptr @test_acosf, ptr @test___umodti3]

define void @_start(ptr %a, ptr %b) #0 {
entry:
call void @llvm.memcpy.p0.p0.i64(ptr %a, ptr %b, i64 1024, i1 false)
ret void
}

; Emit acosf, which currently happens to be the first runtime libcall
; entry.
define float @test_acosf(float %x) {
%acos = call float @llvm.acos.f32(float %x)
ret float %acos
}

; Emit __umodti3, which currently happens to be the last runtime
; libcall entry.
define i128 @test___umodti3(i128 %a, i128 %b) {
%urem = urem i128 %a, %b
ret i128 %urem
}

declare void @llvm.memcpy.p0.p0.i64(ptr nocapture, ptr nocapture, i64, i1)

attributes #0 = { "target-features"="-bulk-memory,-bulk-memory-opt" }
Expand All @@ -22,6 +38,12 @@ attributes #0 = { "target-features"="-bulk-memory,-bulk-memory-opt" }
; CHECK-NEXT: Name: name
; CHECK-NEXT: FunctionNames:
; CHECK-NEXT: - Index: 0
; CHECK-NEXT: Name: _start
; CHECK-NEXT: Name: test_acosf
; CHECK-NEXT: - Index: 1
; CHECK-NEXT: Name: memcpy
; CHECK-NEXT: Name: acosf
; CHECK-NEXT: - Index: 2
; CHECK-NEXT: Name: test___umodti3
; CHECK-NEXT: - Index: 3
; CHECK-NEXT: Name: __umodti3
; CHECK-NEXT: - Index: 4
; CHECK-NEXT: Name: _start
4 changes: 2 additions & 2 deletions llvm/include/llvm/IR/RuntimeLibcalls.h
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ struct RuntimeLibcallsInfo {
}

ArrayRef<RTLIB::LibcallImpl> getLibcallImpls() const {
// Trim Unsupported from the start
return ArrayRef(LibcallImpls).drop_front();
// Trim UNKNOWN_LIBCALL from the back
return ArrayRef(LibcallImpls).drop_back();
}

/// Get the comparison predicate that's to be used to test the result of the
Expand Down
Loading