-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[MLIR][GPU] Add xevm-attach-target transform pass. #147372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
silee2
wants to merge
5
commits into
llvm:main
Choose a base branch
from
silee2:addXeVMAttachTarget
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+142
−4
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f2fd80a
Add xevm-attach-target transform pass.
silee2 b82816a
Add missing file.
silee2 62db26d
Add XeVM dialect as a dependency for xevm-attach-target pass.
silee2 39b3471
Match pass behavior with other attach target passes. Split check line…
silee2 17f139a
Address reviewer comments.
silee2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
//===-- XeVMAttachTarget.cpp - Attach an XeVM target ----------------------===// | ||
// | ||
// This file is licensed under the Apache License v2.0 with LLVM Exceptions. | ||
// See https://llvm.org/LICENSE.txt for license information. | ||
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
// | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This file implements the `GpuXeVMAttachTarget` pass, attaching `#xevm.target` | ||
// attributes to GPU modules. | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
#include "mlir/Dialect/GPU/Transforms/Passes.h" | ||
|
||
#include "mlir/Dialect/GPU/IR/GPUDialect.h" | ||
#include "mlir/Dialect/LLVMIR/XeVMDialect.h" | ||
#include "mlir/IR/Builders.h" | ||
#include "mlir/Pass/Pass.h" | ||
#include "llvm/Support/Regex.h" | ||
|
||
namespace mlir { | ||
#define GEN_PASS_DEF_GPUXEVMATTACHTARGET | ||
#include "mlir/Dialect/GPU/Transforms/Passes.h.inc" | ||
} // namespace mlir | ||
|
||
using namespace mlir; | ||
using namespace mlir::xevm; | ||
|
||
namespace { | ||
struct XeVMAttachTarget | ||
: public mlir::impl::GpuXeVMAttachTargetBase<XeVMAttachTarget> { | ||
using Base::Base; | ||
|
||
DictionaryAttr getFlags(OpBuilder &builder) const; | ||
|
||
void runOnOperation() override; | ||
|
||
void getDependentDialects(DialectRegistry ®istry) const override { | ||
registry.insert<xevm::XeVMDialect>(); | ||
} | ||
}; | ||
} // namespace | ||
|
||
DictionaryAttr XeVMAttachTarget::getFlags(OpBuilder &builder) const { | ||
SmallVector<NamedAttribute, 3> flags; | ||
// Tokenize and set the optional command line options. | ||
if (!cmdOptions.empty()) { | ||
std::pair<llvm::BumpPtrAllocator, SmallVector<const char *>> options = | ||
gpu::TargetOptions::tokenizeCmdOptions(cmdOptions); | ||
if (!options.second.empty()) { | ||
llvm::SmallVector<mlir::Attribute> xevmOptionAttrs; | ||
for (const char *opt : options.second) { | ||
xevmOptionAttrs.emplace_back( | ||
mlir::StringAttr::get(builder.getContext(), StringRef(opt))); | ||
} | ||
flags.push_back(builder.getNamedAttr( | ||
"cmd-options", | ||
mlir::ArrayAttr::get(builder.getContext(), xevmOptionAttrs))); | ||
} | ||
} | ||
|
||
if (!flags.empty()) | ||
return builder.getDictionaryAttr(flags); | ||
return nullptr; | ||
} | ||
|
||
void XeVMAttachTarget::runOnOperation() { | ||
OpBuilder builder(&getContext()); | ||
ArrayRef<std::string> libs(linkLibs); | ||
SmallVector<StringRef> filesToLink(libs); | ||
auto target = builder.getAttr<xevm::XeVMTargetAttr>( | ||
optLevel, triple, chip, getFlags(builder), | ||
filesToLink.empty() ? nullptr : builder.getStrArrayAttr(filesToLink)); | ||
llvm::Regex matcher(moduleMatcher); | ||
for (Region ®ion : getOperation()->getRegions()) | ||
for (Block &block : region.getBlocks()) | ||
for (auto module : block.getOps<gpu::GPUModuleOp>()) { | ||
// Check if the name of the module matches. | ||
if (!moduleMatcher.empty() && !matcher.match(module.getName())) | ||
continue; | ||
// Create the target array. | ||
SmallVector<Attribute> targets; | ||
if (std::optional<ArrayAttr> attrs = module.getTargets()) | ||
targets.append(attrs->getValue().begin(), attrs->getValue().end()); | ||
targets.push_back(target); | ||
// Remove any duplicate targets. | ||
targets.erase(llvm::unique(targets), targets.end()); | ||
// Update the target attribute array. | ||
module.setTargetsAttr(builder.getArrayAttr(targets)); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the name is empty, do you just attach to all GPU modules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get your question.
filesToLink
is files to link, like external spir-v library files. Name would be empty in most cases.Behavior is the same as nvvm-attach-target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so.
When
moduleMatcher
is empty,nvvm
info is attached to all GPU module.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now after updates, this should be the behavior here as well.