-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[mlir][spirv] Fix lookup logic spirv.target_env
for gpu.module
#147262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oojahooo
wants to merge
11
commits into
llvm:main
Choose a base branch
from
oojahooo:spirv_lookup_target
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+48
−4
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5d05b68
[mlir][SPIRV] Fix lookup logic `spirv.target_env` for `gpu.module`
oojahooo 71d3d92
Add test
oojahooo ae6ba9c
Delete braces for complying with conding standard
oojahooo fa3b44e
fixup! [mlir][SPIRV] Fix lookup logic `spirv.target_env` for `gpu.mod…
oojahooo 7d43c59
Remove unnecessary check in test
oojahooo 40b6f07
Add same lookup target env logic in GPUModuleConversion
oojahooo 0b68019
fixup! Add same lookup target env logic in GPUModuleConversion
oojahooo 0833b2a
Update mlir/test/Conversion/GPUToSPIRV/lookup-target-env.mlir
oojahooo a688ec2
Spell out the not obvious types
oojahooo 1f38539
Add documentation comments
oojahooo 9344c20
Simplify pass pipeline of test code
oojahooo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// RUN: mlir-opt --convert-gpu-to-spirv %s | FileCheck %s | ||
|
||
module attributes {gpu.container_module} { | ||
// CHECK-LABEL: spirv.module @{{.*}} GLSL450 | ||
gpu.module @kernels [#spirv.target_env<#spirv.vce<v1.0, [Shader], [SPV_KHR_storage_buffer_storage_class]>, #spirv.resource_limits<>>] { | ||
// CHECK: spirv.func @load_kernel | ||
// CHECK-SAME: %[[ARG:.*]]: !spirv.ptr<!spirv.struct<(!spirv.array<48 x f32, stride=4> [0])>, StorageBuffer> {spirv.interface_var_abi = #spirv.interface_var_abi<(0, 0)>}) | ||
gpu.func @load_kernel(%arg0: memref<12x4xf32>) kernel attributes {spirv.entry_point_abi = #spirv.entry_point_abi<workgroup_size = [16, 1, 1]>} { | ||
%c0 = arith.constant 0 : index | ||
// CHECK: %[[PTR:.*]] = spirv.AccessChain %[[ARG]]{{\[}}{{%.*}}, {{%.*}}{{\]}} | ||
// CHECK-NEXT: {{%.*}} = spirv.Load "StorageBuffer" %[[PTR]] : f32 | ||
%0 = memref.load %arg0[%c0, %c0] : memref<12x4xf32> | ||
// CHECK: spirv.Return | ||
gpu.return | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.