[Test] Account for spaces in paths in the new dtlto/files.test #146749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses LIT substitutions in a response file that could contain spaces in paths. This caused a failure on a build bot where the path to the system Python executable was "C:\Program Files\Python310\python.exe", as reported in llvm#142757. Add appropriate quoting to fix the issue.
|
@llvm/pr-subscribers-lld-elf Author: bd1976bris (bd1976bris) ChangesThis uses LIT substitutions in a response file that could contain spaces in paths. This caused a failure on a build bot where the path to the system Python executable was "C:\Program Files\Python310\python.exe", as reported in #142757. Add appropriate quoting to fix the issue. Full diff: https://github.com/llvm/llvm-project/pull/146749.diff 1 Files Affected:
diff --git a/lld/test/ELF/dtlto/files.test b/lld/test/ELF/dtlto/files.test
index 727ef53c7f5b5..54bcf587f46b9 100644
--- a/lld/test/ELF/dtlto/files.test
+++ b/lld/test/ELF/dtlto/files.test
@@ -24,8 +24,8 @@ RUN: llc t2.ll --filetype=obj -o t2.o
## the contents of the object files supplied on the command line into the
## output object files in job order.
RUN: echo "t1.bc t2.bc --start-lib t3.bc --end-lib -o my.elf \
-RUN: --thinlto-distributor=%python \
-RUN: --thinlto-distributor-arg=%llvm_src_root/utils/dtlto/mock.py \
+RUN: --thinlto-distributor=\"%python\" \
+RUN: --thinlto-distributor-arg=\"%llvm_src_root/utils/dtlto/mock.py\" \
RUN: --thinlto-distributor-arg=t1.o \
RUN: --thinlto-distributor-arg=t2.o" > l.rsp
|
|
@llvm/pr-subscribers-lld Author: bd1976bris (bd1976bris) ChangesThis uses LIT substitutions in a response file that could contain spaces in paths. This caused a failure on a build bot where the path to the system Python executable was "C:\Program Files\Python310\python.exe", as reported in #142757. Add appropriate quoting to fix the issue. Full diff: https://github.com/llvm/llvm-project/pull/146749.diff 1 Files Affected:
diff --git a/lld/test/ELF/dtlto/files.test b/lld/test/ELF/dtlto/files.test
index 727ef53c7f5b5..54bcf587f46b9 100644
--- a/lld/test/ELF/dtlto/files.test
+++ b/lld/test/ELF/dtlto/files.test
@@ -24,8 +24,8 @@ RUN: llc t2.ll --filetype=obj -o t2.o
## the contents of the object files supplied on the command line into the
## output object files in job order.
RUN: echo "t1.bc t2.bc --start-lib t3.bc --end-lib -o my.elf \
-RUN: --thinlto-distributor=%python \
-RUN: --thinlto-distributor-arg=%llvm_src_root/utils/dtlto/mock.py \
+RUN: --thinlto-distributor=\"%python\" \
+RUN: --thinlto-distributor-arg=\"%llvm_src_root/utils/dtlto/mock.py\" \
RUN: --thinlto-distributor-arg=t1.o \
RUN: --thinlto-distributor-arg=t2.o" > l.rsp
|
bd1976bris
requested review from
smithp35,
dyung,
pcc,
aeubanks,
kovdan01,
dgg5503,
nga888,
playstation-edd and
ylzsx
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/25874 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses LIT substitutions in a response file that could contain spaces in paths. This caused a failure on a build bot where the path to the system Python executable was "C:\Program Files\Python310\python.exe", as reported in #142757.
Add appropriate quoting to fix the issue.