-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[AArch64][PAC] Introduce AArch64::PAC pseudo instruction #146488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
atrosinenko
wants to merge
2
commits into
users/atrosinenko/machine-licm-implicit-defs
Choose a base branch
from
users/atrosinenko/pauth-imm-modifier-sign
base: users/atrosinenko/machine-licm-implicit-defs
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+339
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,205 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 5 | ||
; RUN: llc < %s -mtriple arm64e-apple-darwin -verify-machineinstrs -stop-after=finalize-isel -global-isel=0 \ | ||
; RUN: | FileCheck %s --check-prefixes=DAGISEL | ||
; RUN: llc < %s -mtriple arm64e-apple-darwin -verify-machineinstrs -stop-after=finalize-isel -global-isel=1 -global-isel-abort=1 \ | ||
; RUN: | FileCheck %s --check-prefixes=GISEL | ||
; RUN: llc < %s -mtriple aarch64-linux-gnu -mattr=+pauth -verify-machineinstrs -stop-after=finalize-isel -global-isel=0 \ | ||
; RUN: | FileCheck %s --check-prefixes=DAGISEL | ||
; RUN: llc < %s -mtriple aarch64-linux-gnu -mattr=+pauth -verify-machineinstrs -stop-after=finalize-isel -global-isel=1 -global-isel-abort=1 \ | ||
; RUN: | FileCheck %s --check-prefixes=GISEL | ||
|
||
; Check MIR produced by the instruction selector to validate properties that | ||
; cannot be reliably tested by only inspecting the final asm output. | ||
|
||
@discvar = dso_local global i64 0 | ||
|
||
; Make sure the components of blend(addr, imm) are recognized and passed to | ||
; PAC pseudo via separate operands to prevent substitution of the immediate | ||
; modifier. | ||
; | ||
; MIR output of the instruction selector is inspected, as it is hard to reliably | ||
; distinguish MOVKXi immediately followed by a pseudo from a standalone pseudo | ||
; instruction carrying address and immediate modifiers in its separate operands | ||
; by only observing the final asm output. | ||
|
||
define i64 @small_imm_disc(i64 %addr) { | ||
; DAGISEL-LABEL: name: small_imm_disc | ||
; DAGISEL: bb.0.entry: | ||
; DAGISEL-NEXT: liveins: $x0 | ||
; DAGISEL-NEXT: {{ $}} | ||
; DAGISEL-NEXT: [[COPY:%[0-9]+]]:gpr64 = COPY $x0 | ||
; DAGISEL-NEXT: [[MOVi32imm:%[0-9]+]]:gpr32 = MOVi32imm 42 | ||
; DAGISEL-NEXT: [[SUBREG_TO_REG:%[0-9]+]]:gpr64noip = SUBREG_TO_REG 0, killed [[MOVi32imm]], %subreg.sub_32 | ||
; DAGISEL-NEXT: [[PAC:%[0-9]+]]:gpr64 = PAC [[COPY]], 2, 42, killed $noreg, implicit-def dead $x17 | ||
; DAGISEL-NEXT: $x0 = COPY [[PAC]] | ||
; DAGISEL-NEXT: RET_ReallyLR implicit $x0 | ||
; | ||
; GISEL-LABEL: name: small_imm_disc | ||
; GISEL: bb.1.entry: | ||
; GISEL-NEXT: liveins: $x0 | ||
; GISEL-NEXT: {{ $}} | ||
; GISEL-NEXT: [[COPY:%[0-9]+]]:gpr64 = COPY $x0 | ||
; GISEL-NEXT: [[MOVi32imm:%[0-9]+]]:gpr32 = MOVi32imm 42 | ||
; GISEL-NEXT: [[SUBREG_TO_REG:%[0-9]+]]:gpr64noip = SUBREG_TO_REG 0, [[MOVi32imm]], %subreg.sub_32 | ||
; GISEL-NEXT: [[PAC:%[0-9]+]]:gpr64 = PAC [[COPY]], 2, 42, $noreg, implicit-def dead $x17 | ||
; GISEL-NEXT: $x0 = COPY [[PAC]] | ||
; GISEL-NEXT: RET_ReallyLR implicit $x0 | ||
entry: | ||
%signed = call i64 @llvm.ptrauth.sign(i64 %addr, i32 2, i64 42) | ||
ret i64 %signed | ||
} | ||
|
||
define i64 @large_imm_disc_wreg(i64 %addr) { | ||
; DAGISEL-LABEL: name: large_imm_disc_wreg | ||
; DAGISEL: bb.0.entry: | ||
; DAGISEL-NEXT: liveins: $x0 | ||
; DAGISEL-NEXT: {{ $}} | ||
; DAGISEL-NEXT: [[COPY:%[0-9]+]]:gpr64 = COPY $x0 | ||
; DAGISEL-NEXT: [[MOVi32imm:%[0-9]+]]:gpr32 = MOVi32imm 12345678 | ||
; DAGISEL-NEXT: [[SUBREG_TO_REG:%[0-9]+]]:gpr64noip = SUBREG_TO_REG 0, killed [[MOVi32imm]], %subreg.sub_32 | ||
; DAGISEL-NEXT: [[PAC:%[0-9]+]]:gpr64 = PAC [[COPY]], 2, 0, killed [[SUBREG_TO_REG]], implicit-def dead $x17 | ||
; DAGISEL-NEXT: $x0 = COPY [[PAC]] | ||
; DAGISEL-NEXT: RET_ReallyLR implicit $x0 | ||
; | ||
; GISEL-LABEL: name: large_imm_disc_wreg | ||
; GISEL: bb.1.entry: | ||
; GISEL-NEXT: liveins: $x0 | ||
; GISEL-NEXT: {{ $}} | ||
; GISEL-NEXT: [[COPY:%[0-9]+]]:gpr64 = COPY $x0 | ||
; GISEL-NEXT: [[MOVi32imm:%[0-9]+]]:gpr32 = MOVi32imm 12345678 | ||
; GISEL-NEXT: [[SUBREG_TO_REG:%[0-9]+]]:gpr64noip = SUBREG_TO_REG 0, [[MOVi32imm]], %subreg.sub_32 | ||
; GISEL-NEXT: [[PAC:%[0-9]+]]:gpr64 = PAC [[COPY]], 2, 0, [[SUBREG_TO_REG]], implicit-def dead $x17 | ||
; GISEL-NEXT: $x0 = COPY [[PAC]] | ||
; GISEL-NEXT: RET_ReallyLR implicit $x0 | ||
entry: | ||
%signed = call i64 @llvm.ptrauth.sign(i64 %addr, i32 2, i64 12345678) | ||
ret i64 %signed | ||
} | ||
|
||
define i64 @large_imm_disc_xreg(i64 %addr) { | ||
; DAGISEL-LABEL: name: large_imm_disc_xreg | ||
; DAGISEL: bb.0.entry: | ||
; DAGISEL-NEXT: liveins: $x0 | ||
; DAGISEL-NEXT: {{ $}} | ||
; DAGISEL-NEXT: [[COPY:%[0-9]+]]:gpr64 = COPY $x0 | ||
; DAGISEL-NEXT: [[MOVi64imm:%[0-9]+]]:gpr64noip = MOVi64imm 123456789012345 | ||
; DAGISEL-NEXT: [[PAC:%[0-9]+]]:gpr64 = PAC [[COPY]], 2, 0, killed [[MOVi64imm]], implicit-def dead $x17 | ||
; DAGISEL-NEXT: $x0 = COPY [[PAC]] | ||
; DAGISEL-NEXT: RET_ReallyLR implicit $x0 | ||
; | ||
; GISEL-LABEL: name: large_imm_disc_xreg | ||
; GISEL: bb.1.entry: | ||
; GISEL-NEXT: liveins: $x0 | ||
; GISEL-NEXT: {{ $}} | ||
; GISEL-NEXT: [[COPY:%[0-9]+]]:gpr64 = COPY $x0 | ||
; GISEL-NEXT: [[MOVi64imm:%[0-9]+]]:gpr64noip = MOVi64imm 123456789012345 | ||
; GISEL-NEXT: [[PAC:%[0-9]+]]:gpr64 = PAC [[COPY]], 2, 0, [[MOVi64imm]], implicit-def dead $x17 | ||
; GISEL-NEXT: $x0 = COPY [[PAC]] | ||
; GISEL-NEXT: RET_ReallyLR implicit $x0 | ||
entry: | ||
%signed = call i64 @llvm.ptrauth.sign(i64 %addr, i32 2, i64 123456789012345) | ||
ret i64 %signed | ||
} | ||
|
||
define i64 @blend_and_sign_same_bb(i64 %addr) { | ||
; DAGISEL-LABEL: name: blend_and_sign_same_bb | ||
; DAGISEL: bb.0.entry: | ||
; DAGISEL-NEXT: liveins: $x0 | ||
; DAGISEL-NEXT: {{ $}} | ||
; DAGISEL-NEXT: [[COPY:%[0-9]+]]:gpr64 = COPY $x0 | ||
; DAGISEL-NEXT: [[ADRP:%[0-9]+]]:gpr64common = ADRP target-flags(aarch64-page) @discvar | ||
; DAGISEL-NEXT: [[LDRXui:%[0-9]+]]:gpr64 = LDRXui killed [[ADRP]], target-flags(aarch64-pageoff, aarch64-nc) @discvar :: (dereferenceable load (s64) from @discvar) | ||
; DAGISEL-NEXT: [[MOVKXi:%[0-9]+]]:gpr64noip = MOVKXi [[LDRXui]], 42, 48 | ||
; DAGISEL-NEXT: [[COPY1:%[0-9]+]]:gpr64noip = COPY [[LDRXui]] | ||
; DAGISEL-NEXT: [[PAC:%[0-9]+]]:gpr64 = PAC [[COPY]], 2, 42, killed [[COPY1]], implicit-def dead $x17 | ||
; DAGISEL-NEXT: $x0 = COPY [[PAC]] | ||
; DAGISEL-NEXT: RET_ReallyLR implicit $x0 | ||
; | ||
; GISEL-LABEL: name: blend_and_sign_same_bb | ||
; GISEL: bb.1.entry: | ||
; GISEL-NEXT: liveins: $x0 | ||
; GISEL-NEXT: {{ $}} | ||
; GISEL-NEXT: [[COPY:%[0-9]+]]:gpr64 = COPY $x0 | ||
; GISEL-NEXT: [[ADRP:%[0-9]+]]:gpr64common = ADRP target-flags(aarch64-page) @discvar | ||
; GISEL-NEXT: [[LDRXui:%[0-9]+]]:gpr64 = LDRXui [[ADRP]], target-flags(aarch64-pageoff, aarch64-nc) @discvar :: (dereferenceable load (s64) from @discvar) | ||
; GISEL-NEXT: [[MOVKXi:%[0-9]+]]:gpr64noip = MOVKXi [[LDRXui]], 42, 48 | ||
; GISEL-NEXT: [[COPY1:%[0-9]+]]:gpr64noip = COPY [[LDRXui]] | ||
; GISEL-NEXT: [[PAC:%[0-9]+]]:gpr64 = PAC [[COPY]], 2, 42, [[COPY1]], implicit-def dead $x17 | ||
; GISEL-NEXT: $x0 = COPY [[PAC]] | ||
; GISEL-NEXT: RET_ReallyLR implicit $x0 | ||
entry: | ||
%addrdisc = load i64, ptr @discvar | ||
%disc = call i64 @llvm.ptrauth.blend(i64 %addrdisc, i64 42) | ||
%signed = call i64 @llvm.ptrauth.sign(i64 %addr, i32 2, i64 %disc) | ||
ret i64 %signed | ||
} | ||
|
||
; In the below test cases both %addrdisc and %disc are computed (i.e. they are | ||
; neither global addresses, nor function arguments) in a different basic block, | ||
; making them harder to express via ISD::PtrAuthGlobalAddress. | ||
|
||
define i64 @blend_and_sign_different_bbs(i64 %addr, i64 %cond) { | ||
; DAGISEL-LABEL: name: blend_and_sign_different_bbs | ||
; DAGISEL: bb.0.entry: | ||
; DAGISEL-NEXT: successors: %bb.1(0x50000000), %bb.2(0x30000000) | ||
; DAGISEL-NEXT: liveins: $x0, $x1 | ||
; DAGISEL-NEXT: {{ $}} | ||
; DAGISEL-NEXT: [[COPY:%[0-9]+]]:gpr64 = COPY $x1 | ||
; DAGISEL-NEXT: [[COPY1:%[0-9]+]]:gpr64 = COPY $x0 | ||
; DAGISEL-NEXT: [[ADRP:%[0-9]+]]:gpr64common = ADRP target-flags(aarch64-page) @discvar | ||
; DAGISEL-NEXT: [[LDRXui:%[0-9]+]]:gpr64 = LDRXui killed [[ADRP]], target-flags(aarch64-pageoff, aarch64-nc) @discvar :: (dereferenceable load (s64) from @discvar) | ||
; DAGISEL-NEXT: [[MOVKXi:%[0-9]+]]:gpr64 = MOVKXi [[LDRXui]], 42, 48 | ||
; DAGISEL-NEXT: [[COPY2:%[0-9]+]]:gpr64noip = COPY [[MOVKXi]] | ||
; DAGISEL-NEXT: CBZX [[COPY]], %bb.2 | ||
; DAGISEL-NEXT: B %bb.1 | ||
; DAGISEL-NEXT: {{ $}} | ||
; DAGISEL-NEXT: bb.1.next: | ||
; DAGISEL-NEXT: successors: %bb.2(0x80000000) | ||
; DAGISEL-NEXT: {{ $}} | ||
; DAGISEL-NEXT: [[COPY3:%[0-9]+]]:gpr64common = COPY [[COPY2]] | ||
; DAGISEL-NEXT: INLINEASM &nop, 1 /* sideeffect attdialect */, 3866633 /* reguse:GPR64common */, [[COPY3]] | ||
; DAGISEL-NEXT: {{ $}} | ||
; DAGISEL-NEXT: bb.2.exit: | ||
; DAGISEL-NEXT: [[COPY4:%[0-9]+]]:gpr64noip = COPY [[LDRXui]] | ||
; DAGISEL-NEXT: [[PAC:%[0-9]+]]:gpr64 = PAC [[COPY1]], 2, 42, [[COPY4]], implicit-def dead $x17 | ||
; DAGISEL-NEXT: $x0 = COPY [[PAC]] | ||
; DAGISEL-NEXT: RET_ReallyLR implicit $x0 | ||
; | ||
; GISEL-LABEL: name: blend_and_sign_different_bbs | ||
; GISEL: bb.1.entry: | ||
; GISEL-NEXT: successors: %bb.2(0x50000000), %bb.3(0x30000000) | ||
; GISEL-NEXT: liveins: $x0, $x1 | ||
; GISEL-NEXT: {{ $}} | ||
; GISEL-NEXT: [[COPY:%[0-9]+]]:gpr64 = COPY $x0 | ||
; GISEL-NEXT: [[COPY1:%[0-9]+]]:gpr64 = COPY $x1 | ||
; GISEL-NEXT: [[ADRP:%[0-9]+]]:gpr64common = ADRP target-flags(aarch64-page) @discvar | ||
; GISEL-NEXT: [[LDRXui:%[0-9]+]]:gpr64 = LDRXui [[ADRP]], target-flags(aarch64-pageoff, aarch64-nc) @discvar :: (dereferenceable load (s64) from @discvar) | ||
; GISEL-NEXT: [[MOVKXi:%[0-9]+]]:gpr64noip = MOVKXi [[LDRXui]], 42, 48 | ||
; GISEL-NEXT: CBZX [[COPY1]], %bb.3 | ||
; GISEL-NEXT: B %bb.2 | ||
; GISEL-NEXT: {{ $}} | ||
; GISEL-NEXT: bb.2.next: | ||
; GISEL-NEXT: successors: %bb.3(0x80000000) | ||
; GISEL-NEXT: {{ $}} | ||
; GISEL-NEXT: [[COPY2:%[0-9]+]]:gpr64common = COPY [[MOVKXi]] | ||
; GISEL-NEXT: INLINEASM &nop, 1 /* sideeffect attdialect */, 3866633 /* reguse:GPR64common */, [[COPY2]] | ||
; GISEL-NEXT: {{ $}} | ||
; GISEL-NEXT: bb.3.exit: | ||
; GISEL-NEXT: [[COPY3:%[0-9]+]]:gpr64noip = COPY [[LDRXui]] | ||
; GISEL-NEXT: [[PAC:%[0-9]+]]:gpr64 = PAC [[COPY]], 2, 42, [[COPY3]], implicit-def dead $x17 | ||
; GISEL-NEXT: $x0 = COPY [[PAC]] | ||
; GISEL-NEXT: RET_ReallyLR implicit $x0 | ||
entry: | ||
%addrdisc = load i64, ptr @discvar | ||
%disc = call i64 @llvm.ptrauth.blend(i64 %addrdisc, i64 42) | ||
%cond.b = icmp ne i64 %cond, 0 | ||
br i1 %cond.b, label %next, label %exit | ||
|
||
next: | ||
call void asm sideeffect "nop", "r"(i64 %disc) | ||
br label %exit | ||
|
||
exit: | ||
%signed = call i64 @llvm.ptrauth.sign(i64 %addr, i32 2, i64 %disc) | ||
ret i64 %signed | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would probably suggest to use a bit more specific naming. As
blend
also could refer to vector blend operation.