[libc++] P2944R3: Constrained comparisions - tuple
#145677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rapper Implements `variant`: https://wg21.link/P2944R3 Closes llvm#136769
Implements P2944R3 partially, which adds constrained comparisons `std::tuple`. The missing overloads introduced in P2165R4 are not implemented. Relates to llvm#136765 # References [tuple.rel](https://eel.is/c++draft/tuple.rel)
philnik777
requested changes
Jun 25, 2025
libcxx/test/std/utilities/tuple/tuple.tuple/tuple.rel/size_incompatible_comparison.verify.cpp
Outdated
Show resolved
Hide resolved
philnik777
approved these changes
Jun 27, 2025
|
Thank you! AFAIK the failed test are unrelated. Merging! |
h-vetinari
reviewed
Jun 28, 2025
| @@ -59,7 +59,7 @@ | |||
| "`P2248R8 <https://wg21.link/P2248R8>`__","Enabling list-initialization for algorithms","2024-03 (Tokyo)","","","" | |||
| "`P2810R4 <https://wg21.link/P2810R4>`__","``is_debugger_present`` ``is_replaceable``","2024-03 (Tokyo)","","","" | |||
| "`P1068R11 <https://wg21.link/P1068R11>`__","Vector API for random number generation","2024-03 (Tokyo)","","","" | |||
| "`P2944R3 <https://wg21.link/P2944R3>`__","Comparisons for ``reference_wrapper``","2024-03 (Tokyo)","|Partial|","","The changes to ``optional`` and ``tuple`` are not yet implemented" | |||
| "`P2944R3 <https://wg21.link/P2944R3>`__","Comparisons for ``reference_wrapper``","2024-03 (Tokyo)","|Partial|","","The changes to ``optional`` and ``tuple``'s equality overload from P2165R4 are not yet implemented" | |||
There was a problem hiding this comment.
Doesn't this PR implement the tuple changes? 🤔
Suggested change
| "`P2944R3 <https://wg21.link/P2944R3>`__","Comparisons for ``reference_wrapper``","2024-03 (Tokyo)","|Partial|","","The changes to ``optional`` and ``tuple``'s equality overload from P2165R4 are not yet implemented" | |
| "`P2944R3 <https://wg21.link/P2944R3>`__","Comparisons for ``reference_wrapper``","2024-03 (Tokyo)","|Partial|","","The changes to ``optional``'s equality overload from P2165R4 are not yet implemented" |
There was a problem hiding this comment.
We are missing an overload which AFAIK is not trivial to add, so it will be done later.
rlavaee
pushed a commit
to rlavaee/llvm-project
that referenced
this pull request
Jul 1, 2025
Implements P2944R3 partially, which adds constrained comparisons `std::tuple`. The missing overloads introduced in [P2165R4](https://wg21.link/P2165R4) are not implemented. Uses [`__all`](https://github.com/llvm/llvm-project/blob/f7af33a9eb5b3876f219075023dc9c565d75849b/libcxx/include/__type_traits/conjunction.h#L45) instead of a fold expression, see comment: llvm#141396 (comment) Relates to llvm#136765 # References [tuple.rel](https://wg21.link//tuple.rel)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements P2944R3 partially, which adds constrained comparisons
std::tuple.The missing overloads introduced in P2165R4 are not implemented.
Uses
__allinstead of a fold expression, see comment: #141396 (comment)Relates to #136765
References
tuple.rel