Skip to content

[OpenMP] [NFC] Remove dead code: building task stack #143589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[OpenMP] [NFC] Remove dead code: building task stack #143589

wants to merge 1 commit into from

Conversation

jpeyton52
Copy link
Contributor

This code hasn't been enabled since the first code changes were introduced. Remove the dead code.

@jpeyton52
[OpenMP] [NFC] Remove dead code: building task stack
72f5bc2 
This code hasn't been enabled since the first code changes were
introduced. Remove the dead code.
@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label Jun 10, 2025
jprotze
jprotze approved these changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@jprotze jprotze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm
All removed code is guarded with BUILD_TIED_TASK_STACK and the PR removes all uses of this macro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprotze jprotze jprotze approved these changes

@TerryLWilmarth TerryLWilmarth Awaiting requested review from TerryLWilmarth

@hansangbae hansangbae Awaiting requested review from hansangbae

Assignees
No one assigned
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpeyton52 @jprotze @llvmbot