-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[clang][SYCL] Add sycl_external attribute and restrict emitting device code #140282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @schittir! I completed an initial pass of all of the code, but still need to look more closely at the documentation updates.
Thank you for the initial pass review, Tom! |
✅ With the latest revision this PR passed the C/C++ code formatter. |
Support for functions is sufficient for SYCL 2020 spec conformance.
Co-authored-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @schittir, here are my initial review comments. I expect to review the newly added tests more closely once these comments are all addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing most of my earlier comments. I took another quick look today and added a couple more comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional comments for diagnostics and tests.
There seems to be an issue with the use of sycl_kernel_entry_point attribute vs __builtin_unique_stable_name
Oops new tests are failing. |
This patch is part of the upstreaming effort for supporting SYCL language front end.
It makes the following changes: