[CodeGen][NPM] Account inserted passes for -start/stop options #138830
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 7, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 7, 2025
paperchalice
approved these changes
May 7, 2025
optimisan
force-pushed
the
users/optimisan/pb/inserted-start-stop
branch
from
da7bc1e to
67f7f32
Compare
optimisan
force-pushed
the
users/optimisan/port/process-imp-defs
branch
from
4c6166a to
0977795
Compare
This was referenced May 12, 2025
optimisan
force-pushed
the
users/optimisan/port/process-imp-defs
branch
from
0977795 to
770472d
Compare
optimisan
force-pushed
the
users/optimisan/pb/inserted-start-stop
branch
from
67f7f32 to
eb703f4
Compare
optimisan
force-pushed
the
users/optimisan/port/process-imp-defs
branch
from
770472d to
4f58c44
Compare
optimisan
force-pushed
the
users/optimisan/pb/inserted-start-stop
branch
from
eb703f4 to
b0f06a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly solves the issue #138831 for
-enable-new-pm.TargetPassBuilder#137290 will not have this problem, but I am adding this till we migrate to the new pass builder structure.Even with this, there is no way to
-start-afteran inserted pass right now.