Skip to content

Commit 20864c4

Browse files
authored
[LAA] Strip outdated comment in isDependent (NFC) (#146367)
The comment has been outdated since 87ddd3a ([LAA] Rename and fix semantics of MaxSafeDepDistBytes to MinDepDistBytes).
1 parent 9d9d68f commit 20864c4

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

llvm/lib/Analysis/LoopAccessAnalysis.cpp

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2256,22 +2256,6 @@ MemoryDepChecker::isDependent(const MemAccessInfo &A, unsigned AIdx,
22562256
return Dependence::Backward;
22572257
}
22582258

2259-
// Positive distance bigger than max vectorization factor.
2260-
// FIXME: Should use max factor instead of max distance in bytes, which could
2261-
// not handle different types.
2262-
// E.g. Assume one char is 1 byte in memory and one int is 4 bytes.
2263-
// void foo (int *A, char *B) {
2264-
// for (unsigned i = 0; i < 1024; i++) {
2265-
// A[i+2] = A[i] + 1;
2266-
// B[i+2] = B[i] + 1;
2267-
// }
2268-
// }
2269-
//
2270-
// This case is currently unsafe according to the max safe distance. If we
2271-
// analyze the two accesses on array B, the max safe dependence distance
2272-
// is 2. Then we analyze the accesses on array A, the minimum distance needed
2273-
// is 8, which is less than 2 and forbidden vectorization, But actually
2274-
// both A and B could be vectorized by 2 iterations.
22752259
MinDepDistBytes =
22762260
std::min(static_cast<uint64_t>(MinDistance), MinDepDistBytes);
22772261

0 commit comments

Comments
 (0)