[CIR][CIRGen][Builtin][X86] Lower mm_prefetch #1675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of things I have questions about:
I duplicated function
getIntValueFromConstOp
fromCIRGenBuiltinAArch64.cpp
. I was wondering if that's correct or if there's a place where we can avoid that duplication.For the tests related to
mm_prefetch
im not sure if it'd be correct to define them in a file eg:sse-builtins.c
like it's currently done in the codegen lib.I'm also aware we can emit a call for a
PreFetchOp
would that be required in this case?related: #1414 (A PR was also opened but It was not resolved)