PHPStan issues addressed

Author: lloc

includes/ContentImport/AttachmentPathFinder.php

@@ -8,7 +8,15 @@ class AttachmentPathFinder extends MslsRegistryInstance {
 
 	const LINKED = '_msls_linked';
 
-	public function filter_srcset( array $sources, $sizeArray, $imageSrc, $imageMeta, $attachmentId ) {
+	/**
+	 * @param array  $sources
+	 * @param mixed  $sizeArray
+	 * @param string $imageSrc
+	 * @param mixed  $imageMeta
+	 * @param int    $attachmentId
+	 * @return array
+	 */
+	public function filter_srcset( array $sources, $sizeArray, $imageSrc, $imageMeta, $attachmentId ): array {
 		if ( ! $msls_imported = $this->has_import_data( $attachmentId ) ) {
 			return $sources;
 		}
@@ -32,6 +40,10 @@ public function filter_srcset( array $sources, $sizeArray, $imageSrc, $imageMeta
 		return $sources;
 	}
 
+	/**
+	 * @param int $attachment_id
+	 * @return array|false
+	 */
 	protected function has_import_data( $attachment_id ) {
 		if ( empty( $attachment_id ) ) {
 			return false;
@@ -53,6 +65,11 @@ protected function has_import_data( $attachment_id ) {
 		return $msls_imported;
 	}
 
+	/**
+	 * @param string $url
+	 * @param int    $attachment_id
+	 * @return string
+	 */
 	public function filter_attachment_url( $url, $attachment_id ) {
 		if ( ! $msls_imported = $this->has_import_data( $attachment_id ) ) {
 			return $url;
@@ -68,7 +85,7 @@ public function filter_attachment_url( $url, $attachment_id ) {
 	}
 
 	/**
-	 * @param int $attachment_id
+	 * @param int   $attachment_id
 	 * @param array $msls_imported
 	 *
 	 * @return \WP_Post|false
@@ -84,4 +101,4 @@ protected function get_source_post( $attachment_id, $msls_imported ) {
 
 		return $source_post;
 	}
-}
+}

includes/ContentImport/ContentImporter.php

@@ -63,7 +63,7 @@ public function get_logger() {
 	/**
 	 * @param \lloc\Msls\ContentImport\ImportLogger $logger
 	 */
-	public function set_logger( $logger ) {
+	public function set_logger( $logger ): void {
 		$this->logger = $logger;
 	}
 
@@ -77,7 +77,7 @@ public function get_relations() {
 	/**
 	 * @param \lloc\Msls\ContentImport\Relations $relations
 	 */
-	public function set_relations( $relations ) {
+	public function set_relations( $relations ): void {
 		$this->relations = $relations;
 	}
 
@@ -179,6 +179,11 @@ public function parse_sources() {
 		return array_map( 'intval', $import_data );
 	}
 
+	/**
+	 * @param int $blog_id
+	 *
+	 * @return int
+	 */
 	protected function get_the_blog_post_ID( $blog_id ) {
 		switch_to_blog( $blog_id );
 
@@ -331,9 +336,9 @@ public function import_content( ImportCoordinates $import_coordinates, array $po
 	}
 
 	/**
-	 * @param array $data
+	 * @param int   $blog_id
 	 * @param int   $post_id
-	 *
+	 * @param array $data
 	 * @return array
 	 */
 	protected function update_inserted_blog_post_data( $blog_id, $post_id, array $data ) {
@@ -346,6 +351,11 @@ protected function update_inserted_blog_post_data( $blog_id, $post_id, array $da
 		return $data;
 	}
 
+	/**
+	 * @param int $dest_blog_id
+	 * @param int $post_id
+	 * @return void
+	 */
 	protected function redirect_to_blog_post( $dest_blog_id, $post_id ) {
 		switch_to_blog( $dest_blog_id );
 		$edit_post_link = html_entity_decode( get_edit_post_link( $post_id ) );

includes/ContentImport/ImportCoordinates.php

@@ -44,7 +44,7 @@ class ImportCoordinates {
 	 * @var array An array keeping track of which importer (slug) should be used for
 	 *            a specific import type, shape [ <import-type> => <slug> ]
 	 */
-	public $importers = [];
+	public $importers = array();
 
 	/**
 	 * Validates the coordinates.
@@ -88,11 +88,11 @@ public function get_importer_for( $importer_type ) {
 	/**
 	 * Parses the importers from request superglobals.
 	 */
-	public function parse_importers_from_request() {
+	public function parse_importers_from_request(): void {
 		// bitmask
 		$source = isset( $_REQUEST[ self::IMPORTERS_GLOBAL_KEY ] ) * 100
-		          + isset( $_POST[ self::IMPORTERS_GLOBAL_KEY ] ) * 10
-		          + isset( $_GET[ self::IMPORTERS_GLOBAL_KEY ] );
+					+ isset( $_POST[ self::IMPORTERS_GLOBAL_KEY ] ) * 10
+					+ isset( $_GET[ self::IMPORTERS_GLOBAL_KEY ] );
 
 		switch ( $source ) {
 			case 100:
@@ -114,7 +114,7 @@ public function parse_importers_from_request() {
 
 		$importers = isset( $source[ self::IMPORTERS_GLOBAL_KEY ] ) && is_array( $source[ self::IMPORTERS_GLOBAL_KEY ] )
 			? $source[ self::IMPORTERS_GLOBAL_KEY ]
-			: [];
+			: array();
 
 		foreach ( $importers as $importer_type => $slug ) {
 			$this->set_importer_for( $importer_type, $slug );
@@ -127,7 +127,7 @@ public function parse_importers_from_request() {
 	 * @param string $importer_type
 	 * @param string $slug
 	 */
-	public function set_importer_for( $importer_type, $slug ) {
+	public function set_importer_for( $importer_type, $slug ): void {
 		$this->importers[ $importer_type ] = $slug;
 	}
 }