PHPStan issues for ImportLogger solved

Author: lloc

includes/ContentImport/ImportLogger.php

@@ -51,17 +51,16 @@ public function get_data(): array {
 	 * Saves the log or prints it some place.
 	 */
 	public function save(): void {
-		$log_writer = $default_log_writer = AdminNoticeLogger::instance();
-		$log_writer->set_import_coordinates( $this->import_coordinates );
+		$default_log_writer = AdminNoticeLogger::instance();
+		$default_log_writer->set_import_coordinates( $this->import_coordinates );
 
 		/**
 		 * Filters the log class or object that should be used to write the log to the destination.
 		 *
-		 * @param LogWriter $log_writer
+		 * @param mixed $default_log_writer
 		 * @param ImportCoordinates $import_coordinates
 		 */
-		$log_writer = apply_filters( 'msls_content_import_log_writer', $log_writer, $this->import_coordinates );
-
+		$log_writer = apply_filters( 'msls_content_import_log_writer', $default_log_writer, $this->import_coordinates );
 		if ( empty( $log_writer ) ) {
 			// we assume that was done on purpose to prevent logging
 			return;
@@ -106,6 +105,12 @@ protected function log( $where, $what, $root = 'info' ): void {
 		$this->data[ $root ] = array_merge_recursive( $this->data[ $root ], $data );
 	}
 
+	/**
+	 * @param array $path
+	 * @param mixed $what
+	 *
+	 * @return array
+	 */
 	protected function build_nested_array( $path, $what = '' ): array {
 		$json = '{"'
 				. implode( '":{"', $path )
@@ -124,11 +129,11 @@ protected function build_nested_array( $path, $what = '' ): array {
 	}
 
 	/**
-	 * @param $where
+	 * @param string $where
 	 *
 	 * @return array
 	 */
-	protected function build_path( $where ): array {
+	protected function build_path( string $where ): array {
 		$where_path = explode( $this->levels_delimiter, $where );
 
 		return $where_path;
@@ -165,6 +170,7 @@ public function log_success( $where, $what ): void {
 	/**
 	 * Logs some generic information.
 	 *
+	 * @param string $key
 	 * @param string $message
 	 */
 	public function log_information( $key, $message ): void {

includes/ContentImport/Importers/ImportersBaseFactory.php

@@ -34,7 +34,7 @@ public function make( ImportCoordinates $import_coordinates ) {
 		 *
 		 * Returning an Importer instance here will force the class to return that.
 		 *
-		 * @param                   $importer Importer
+		 * @param ?Importer         $importer
 		 * @param ImportCoordinates $import_coordinates
 		 */
 		$importer = apply_filters( "msls_content_import_{$type}_importer", null, $import_coordinates );
@@ -81,21 +81,25 @@ public function details() {
 	 * @return string
 	 */
 	public function selected() {
-		$selected = array_keys( $this->importers_map )[0];
 		$slug     = static::TYPE;
+		$selected = array_keys( $this->importers_map )[0];
+		$instance = $this;
 
 		/**
 		 * Filters the selected importer that among the available ones.
 		 *
 		 * @param string $selected The selected importer slug.
-		 * @param ImportersFactory $this
+		 * @param ImportersFactory $instance
 		 */
-		$selected = apply_filters( "msls_content_import_{$slug}_selected", $selected, $this );
+		$selected = apply_filters( "msls_content_import_{$slug}_selected", $selected, $instance );
 
 		return $selected;
 	}
 
-	protected function importers_info() {
+	/**
+	 * @return array<string, \stdClass>
+	 */
+	protected function importers_info(): array {
 		return array_combine(
 			array_keys( $this->importers_map ),
 			array_map(

includes/ContentImport/Importers/PostFields/Duplicating.php

@@ -2,6 +2,7 @@
 
 namespace lloc\Msls\ContentImport\Importers\PostFields;
 
+use lloc\Msls\ContentImport\ImportCoordinates;
 use lloc\Msls\ContentImport\Importers\BaseImporter;
 use lloc\Msls\ContentImport\Importers\WithRequestPostAttributes;
 
@@ -23,11 +24,11 @@ class Duplicating extends BaseImporter {
 	 * @return \stdClass
 	 */
 	public static function info() {
-		return (object) [
+		return (object) array(
 			'slug'        => static::TYPE,
 			'name'        => __( 'Duplicating', 'multisite-language-switcher' ),
-			'description' => __( 'Copies the source post fields to the destination.', 'multisite-language-switcher' )
-		];
+			'description' => __( 'Copies the source post fields to the destination.', 'multisite-language-switcher' ),
+		);
 	}
 
 	public function import( array $data ) {
@@ -39,11 +40,11 @@ public function import( array $data ) {
 		foreach ( $this->filter_fields() as $field ) {
 			$value          = $source_post->{$field};
 			$data[ $field ] = $value;
-			$this->logger->log_success( 'post-field/added', [ $field => $value ] );
+			$this->logger->log_success( 'post-field/added', array( $field => $value ) );
 		}
 
 		if ( ! doing_action( 'wp_insert_post_data' ) ) {
-			$postarr = array_merge( $data, [ 'ID' => $this->import_coordinates->dest_post_id ] );
+			$postarr = array_merge( $data, array( 'ID' => $this->import_coordinates->dest_post_id ) );
 			wp_insert_post( $postarr );
 		}
 

tests/phpunit/ContentImport/TestContentImporter.php

@@ -7,6 +7,7 @@
 use lloc\Msls\ContentImport\Relations;
 use lloc\Msls\MslsMain;
 use lloc\MslsTests\MslsUnitTestCase;
+use Brain\Monkey\Actions;
 
 class TestContentImporter extends MslsUnitTestCase {
 
@@ -15,6 +16,7 @@ public function setUp(): void {
 		parent::setUp();
 
 		$main = \Mockery::mock( MslsMain::class );
+		$main->shouldReceive( 'verify_nonce' )->andReturnTrue();
 
 		$this->test = new ContentImporter( $main );
 	}
@@ -30,4 +32,28 @@ public function test_relations(): void {
 
 		$this->assertInstanceOf( Relations::class, $this->test->get_relations() );
 	}
+
+	public function test_handle_import() {
+		$this->assertEquals( array(), $this->test->handle_import() );
+	}
+
+	public function test_parse_sources_no_post() {
+		$this->assertFalse( $this->test->parse_sources() );
+	}
+
+	public function test_handle_false() {
+		$this->expectNotToPerformAssertions();
+
+		Actions\expectAdded( 'msls_main_save' )->once();
+
+		$this->test->handle( false );
+	}
+
+	public function test_handle_true() {
+		$this->expectNotToPerformAssertions();
+
+		Actions\expectRemoved( 'msls_main_save' )->once();
+
+		$this->test->handle( true );
+	}
 }