Pd support #94
Open
Pd support #94
+149
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecode fields Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Update config_test to use a function to create configuration same as defined in the config yaml file Signed-off-by: Maya Barnea <mayab@il.ibm.com>
change command line argument name to 'kv-cache-transfer-latency' Signed-off-by: Maya Barnea <mayab@il.ibm.com>
irar2
requested changes
Jul 15, 2025
| ) | ||
|
|
||
| DescribeTable("invalid configurations", | ||
| func(args []string) { | ||
| _, err := createSimConfig(args) | ||
| Expect(err).To(HaveOccurred()) | ||
| }, | ||
| Entry(tests[7].name, tests[7].args), |
There was a problem hiding this comment.
You removed a test here instead of only increasing the indices
|
|
||
| return c | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this is confusing, and one function is enough. There is only one case for createDefaultBasicConfig, and we can just update the lora parameters in the test.
There was a problem hiding this comment.
basicConfig function was removed
| // isDoRemoteDecode() returns true is do_remote_decode is true in the request, this means that this is prefill request | ||
| doRemoteDecode() bool | ||
| // isDoRemotePrefill() returns true is do_remote_prefill is true in the request, this means that this is decode request | ||
| doRemotePrefill() bool |
There was a problem hiding this comment.
The names in the comments don't match the actual names
pkg/llm-d-inference-sim/request.go
Outdated
| RemoteBlockIds []string `json:"remote_block_ids"` | ||
| RemoteEngineId string `json:"remote_engine_id"` | ||
| RemoteHost string `json:"remote_host"` | ||
| RemotePort int `json:"remote_port"` |
There was a problem hiding this comment.
Consider adding comments for the fields
pkg/llm-d-inference-sim/response.go
Outdated
| RemoteBlockIds []string `json:"remote_block_ids"` | ||
| RemoteEngineId string `json:"remote_engine_id"` | ||
| RemoteHost string `json:"remote_host"` | ||
| RemotePort int `json:"remote_port"` |
| @@ -304,6 +306,8 @@ func (s *VllmSimulator) readRequest(ctx *fasthttp.RequestCtx, isChatCompletion b | |||
| var req textCompletionRequest | |||
|
|
|||
| err := json.Unmarshal(ctx.Request.Body(), &req) | |||
|
|
|||
| fmt.Printf("Unmarshaled text request: %#v\n", req) | |||
| return &req, err | |||
pkg/llm-d-inference-sim/simulator.go
Outdated
| @@ -477,16 +491,23 @@ func (s *VllmSimulator) reqProcessingWorker(ctx context.Context, id int) { | |||
| isChatCompletion: reqCtx.isChatCompletion, | |||
| model: displayModel, | |||
| }, | |||
| responseTokens, toolCalls, finishReason, usageDataToSend, | |||
| responseTokens, toolCalls, finishReason, usageDataToSend, req.doRemotePrefill(), | |||
There was a problem hiding this comment.
Maybe add doRemotePrefill to streamingContext?
pkg/llm-d-inference-sim/simulator.go
Outdated
| @@ -638,6 +671,14 @@ func (s *VllmSimulator) sendResponse(isChatCompletion bool, ctx *fasthttp.Reques | |||
| s.responseSentCallback(modelName) | |||
| } | |||
|
|
|||
| // returns time to first token based on whether | |||
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.