Skip to content

Add internal attributes definition helper #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add internal attributes definition helper #1534

wants to merge 3 commits into from

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented May 27, 2025

No description provided.

@lukasIO lukasIO requested review from bcherry and davidzhao May 27, 2025 10:57
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 27, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: e279777

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 27, 2025 •
edited
Loading

size-limit report 📦

Path Size
dist/livekit-client.esm.mjs 78.15 KB (-0.06% 🔽)
dist/livekit-client.umd.js 84.16 KB (+0.24% 🔺)

bcherry
bcherry approved these changes May 28, 2025
View reviewed changes
src/room/attributes/agent_attr.ts
@@ -0,0 +1,73 @@
// This file is auto-generated. Do not edit manually.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the auto-generation occurs elsewhere, maybe worth updating these comments with a link to it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, currently restructuring the code gen anyways to support JSON parsing so holding off until that's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcherry bcherry bcherry approved these changes

@davidzhao davidzhao Awaiting requested review from davidzhao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasIO @bcherry