refactor: improve import formatting and type hinting consistency across modules #4058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/contrib
github-actions
bot
added
area/docs
| @@ -80,7 +80,7 @@ def create_string_constrained_field_schema( | |||
| schema.max_length = kwarg_definition.max_length | |||
| if kwarg_definition.pattern: | |||
| schema.pattern = ( | |||
| kwarg_definition.pattern.pattern # type: ignore[attr-defined] | |||
| kwarg_definition.pattern.pattern # type: ignore[attr-defined,unused-ignore] | |||
There was a problem hiding this comment.
Suggested change
| kwarg_definition.pattern.pattern # type: ignore[attr-defined,unused-ignore] | |
| kwarg_definition.pattern.pattern |
There was a problem hiding this comment.
For some reason this is raising linter errors locally but not in CI. I'm wondering if it's a difference between pylance/pyright?
| @@ -22,5 +22,5 @@ def get_typed_init(self, type_: Any) -> tuple[Signature, dict[str, Any]]: | |||
| inspect.Parameter(name=field_name, kind=inspect.Parameter.KEYWORD_ONLY, annotation=Any) | |||
| for field_name in model_fields | |||
| ] | |||
| type_hints = {field_name: Any for field_name in model_fields} | |||
| type_hints = dict.fromkeys(model_fields, Any) | |||
There was a problem hiding this comment.
I personally find the other method more readable as it's more explicit
There was a problem hiding this comment.
This is a Ruff automated upgrade that's been recently added.
provinzkraut
requested changes
Mar 19, 2025
|
I'm not sure why the documentation tests are hanging. I'll have to take a deeper look at this. I haven't another PR that's doing the same thing. |
…ss modules This PR also updates the dependency and tests against the latest versions of ruff and pyright.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also updates the dependency and tests against the latest versions of ruff and pyright.
There are also a few documentations related updates for Advanced Alchemy 1.0