Improve langauge_kdl #479
Open
Improve langauge_kdl #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tamnac
commented
Sep 10, 2024
Tamnac
commented
- fix formatting (should be all 2-space indents now)
- couple of improvements suggested by @Guldoman
- add support for node and nested multiline comments (also thanks to guldoman)
Guldoman
reviewed
Sep 20, 2024
Comment on lines
+48
to
+51
| { | ||
| pattern = { "/%-.*{", "}" }, | ||
| type = "comment", syntax = node_comment | ||
| }, |
There was a problem hiding this comment.
My suggestion in #477 also covered comments like this:
mynode /-"commented" "not commented" {
a
b
}This doesn't, right?
There was a problem hiding this comment.
Yes, your suggestion was very helpful but it only 80% worked, so I made some tweaks. This is how it behaves now, which I believe matches the spec
There was a problem hiding this comment.
Nope, only the single parameter should be commented.
In what cases did my suggestion not work?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.