Skip to content

Symbol Rename #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Symbol Rename #131

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
02a437d
feat: added initial support to refactoring symbols
Jul 10, 2024
6de58d5
fix: workaround for getting current token without spaces
Jul 12, 2024
17be68e
feat: support different reply and support to apply_changes
Jul 12, 2024
16c3819
checking symbol is not nil
Jul 13, 2024
3d516ab
fix: using regex for cleaning symbol string
Jul 14, 2024
3ceee49
added rename capability
Jul 18, 2024
4e1170f
added menu entry
Jul 18, 2024
c33582c
checking error response
Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 33 additions & 17 deletions init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1723,7 +1723,6 @@ end
---@param new_name string
function lsp.request_symbol_rename(doc, line, col, new_name)
if not doc.lsp_open then return end

local servers_found = false
for _, name in pairs(lsp.get_active_servers(doc.filename, true)) do
servers_found = true
Expand All @@ -1736,12 +1735,25 @@ function lsp.request_symbol_rename(doc, line, col, new_name)
callback = function(server, response)
if response.result and #response.result.changes then
for file_uri, changes in pairs(response.result.changes) do
core.log(file_uri .. " " .. #changes)
-- TODO: Finish implement textDocument/rename
file_uri = string.sub(file_uri, 8)
local buff = core.open_doc(file_uri)
core.root_view:open_doc(buff)
for i, change in ipairs(changes) do
local l1, c1 = change.range.start.line + 1, change.range.start.character + 1
local l2, c2 = change.range['end'].line + 1, change.range['end'].character + 1
if #buff.selections > 1 then
buff:add_selection(l1, c1, l2, c2)
else
buff:set_selection(l1, c1, l2, c2)
end
end
for i, change in ipairs(changes) do
local l1, c1 = change.range.start.line + 1, change.range.start.character + 1
local l2, c2 = change.range['end'].line + 1, change.range['end'].character + 1
buff:replace_cursor(i, l1, c1, l2, c2, function(old) return new_name, true end)
end
end
end

core.log("%s", json.prettify(json.encode(response)))
end
})
return
Expand Down Expand Up @@ -2469,18 +2481,22 @@ command.add(
end,

["lsp:rename-symbol"] = function(doc)
local symbol = doc:get_text(doc:get_selection())
local line1, col1, line2 = doc:get_selection()
if #symbol > 0 and line1 == line2 then
core.command_view:enter("New Symbol Name", {
text = symbol,
submit = function(new_name)
lsp.request_symbol_rename(doc, line1, col1, new_name)
end
})
else
core.log("Please select a symbol on the document to rename.")
end
local symbol = doc:get_text(doc:get_selection())
local line1, col1, line2, col2 = doc:get_selection()
if #symbol == 0 then
line1, col1, line2, col2 = get_token_range(doc, line1, col1)
symbol = doc:get_text(line1, col1, line2, col2)
end
if #symbol > 0 and line1 == line2 then
core.command_view:enter("New Symbol Name", {
text = symbol,
submit = function(new_name)
lsp.request_symbol_rename(doc, line1, col1, new_name)
end
})
else
core.log("Please select a symbol on the document to rename.")
end
end,

["lsp:find-references"] = function(doc)
Expand Down