*Stalled* MSI PRO Z790-P (DDR5) - coreboot 25.03

[Tonux599]

3mdeb upstreamed their work on the MSI boards to coreboot master, and seems to be up-to-date with coreboot 25.03.

This PR builds heads for MSI PRO Z790-P (DDR5) based on coreboot 25.03. We're avoiding dasharo-blobs by fetching MSI's BIOS and extracting the relevant blobs.

I don't actually own this board yet, I'm expecting it in about 2 weeks.

This build does not use HOTP and USB keyboard. I don't own the other MSI variants, so they won't be part of this PR.

There's a fair few cherry-picked commits based on 3mdebs own work on their Heads branch. @miczyg1 and @mkopec let me know if you are happy with how I've picked/implemented these.

TODO List (more will be added as I think of them, and please comment any additions):

• Verify it boots
• Verify that dTPM functions with HAP bit set. Integrate dTPM with HAP enabled in EDK/UEFI on MSI boards  Dasharo/dasharo-issues#1039
• Verify that boot is measured and PCR's are filled.
• Verify it can be flashed using MSI's "FlashBIOS" button thing. Not doing this until (or if) MSI MFlash and FlashBIOS support Dasharo/coreboot#357 is upstreamed.
• Verify flashing works internally within heads
• Verify PS/2 Keyboard functions PS/2 keyboard for dasharo/heads Dasharo/dasharo-issues#1189 (comment)
• Sign-off commits
• Add coreboot 25.03 to CI save_cache
• Investigate kernel panics happening often.

This PR will remain draft until the above TODO list is complete and CI passes.

My thanks to those at 3mdeb for their work supporting this board in coreboot, and their work on their heads branch.

[miczyg1]

let me know if you are happy with how I've picked/implemented these.

LGTM.

Verify it can be flashed using MSI's "FlashBIOS" button thing.

It won't work with upstream coreboot.

[Tonux599]

Verify it can be flashed using MSI's "FlashBIOS" button thing.

It won't work with upstream coreboot.

Thanks. Should we expect internal flashing (when adding PGP keys for example) to work then?

[miczyg1]

Verify it can be flashed using MSI's "FlashBIOS" button thing.

It won't work with upstream coreboot.

Thanks. Should we expect internal flashing (when adding PGP keys for example) to work then?

By default the Z790-P board came with the descriptor locked, so IFD and ME regions are read-only when flashing internally. Should be fine with flashing just the BIOS region, but otherwise it won't (e.g. if HAP bit is desired)

[Tonux599]

@miczyg1 it seems that Dasharo/coreboot#404 was not upstreamed to coreboot. Is that correct? I can create a patch to be applied here based on that PR, but could avoid using patches if it was included in a future release of coreboot.

[miczyg1]

@miczyg1 it seems that Dasharo/coreboot#404 was not upstreamed to coreboot. Is that correct? I can create a patch to be applied here based on that PR, but could avoid using patches if it was included in a future release of coreboot.

Yes, it wasn't. Same with Dasharo/coreboot#357 (and many others)... I had no time to upstream it.

These patches will be large.

[Tonux599]

@miczyg1 it seems that Dasharo/coreboot#404 was not upstreamed to coreboot. Is that correct? I can create a patch to be applied here based on that PR, but could avoid using patches if it was included in a future release of coreboot.

Yes, it wasn't. Same with Dasharo/coreboot#357 (and many others)... I had no time to upstream it.

These patches will be large.

Dasharo/coreboot#404 seems to patch cleanly. I'm less bothered about Dasharo/coreboot#357 unless it affects the internal updating of heads.

@miczyg1 I'm not as familiar as you with submitting coreboot patches, but I would be happy to spend time upstreaming your work, if I'm allowed to even though I'm not the author. Otherwise, if there is anything else I can do to support you to upstream don't hesitate to contact me.

[miczyg1]

@miczyg1 I'm not as familiar as you with submitting coreboot patches, but I would be happy to spend time upstreaming your work, if I'm allowed to even though I'm not the author. Otherwise, if there is anything else I can do to support you to upstream don't hesitate to contact me.

coreboot gerrit review system can distinguish a patch author from patch uploader. As long as you preserve the commit metadata, everything should be allright. I could upload the fan control patches so that I can be the owner of the patch series (it allows me to control it, like set WIP, etc.).

[miczyg1]

Pushed the patches for fan control @Tonux599 :

https://review.coreboot.org/c/coreboot/+/87476
https://review.coreboot.org/c/coreboot/+/87477
https://review.coreboot.org/c/coreboot/+/87478

[Tonux599]

Pushed the patches for fan control @Tonux599 :

https://review.coreboot.org/c/coreboot/+/87476 https://review.coreboot.org/c/coreboot/+/87477 https://review.coreboot.org/c/coreboot/+/87478

Amazing! Thank you!

[Tonux599]

Currently testing on my board but still no TPM for now (hopefully comes sometime this week). Heads boots and internal flashing works with flashprog.

@mdrobnak I hope you don't mind that I cherry picked 41d6391.

@miczyg1 @mkopec I did cherry pick Dasharo#7 at the beginning but now presume we don't need it because we're using MSI's default layout? I'm going to revert and test but would like your input too.

Also around 20% of boots result in a kernel panic. Not sure why yet, will investigate.

[Tonux599]

@miczyg1 I'm getting frequent kernel panics (in heads only, not when booted to Qubes) like:

mce: CPUs not responding to MCE broadcast (may include false positives): 2-3
Kernel panic - not syncing: Timeout: Not all CPUs entered broadcast exception handler

Looking around about MCE's, I came across your issue below, do you think they are related?
https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/MW44TIEMFMVDWPVCAFPE2QUFXXGZYYAX/

[Tonux599]

@miczyg1 I'm getting frequent kernel panics (in heads only, not when booted to Qubes) like:

mce: CPUs not responding to MCE broadcast (may include false positives): 2-3
Kernel panic - not syncing: Timeout: Not all CPUs entered broadcast exception handler

Looking around about MCE's, I came across your issue below, do you think they are related? https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/MW44TIEMFMVDWPVCAFPE2QUFXXGZYYAX/

I can't reproduce this error on Dasharo's Heads v0.9.0. The kernel version is the same, so I think it's either a coreboot configuration issue, or microcode. My builds have 0x12c whilst Dasharo v0.9.0 was something much older. I'll try using an older microcode.

[Tonux599]

@miczyg1 I'm getting frequent kernel panics (in heads only, not when booted to Qubes) like:

mce: CPUs not responding to MCE broadcast (may include false positives): 2-3
Kernel panic - not syncing: Timeout: Not all CPUs entered broadcast exception handler

Looking around about MCE's, I came across your issue below, do you think they are related? https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/MW44TIEMFMVDWPVCAFPE2QUFXXGZYYAX/

I can't reproduce this error on Dasharo's Heads v0.9.0. The kernel version is the same, so I think it's either a coreboot configuration issue, or microcode. My builds have 0x12c whilst Dasharo v0.9.0 was something much older. I'll try using an older microcode.

Downgraded the microcode on my build to 0x119, which is what Dasharo v0.9.0 was on and panic still happening. So presumably something in either the coreboot source (anything of relevance not been upstreamed @miczyg1?) or something in the coreboot config.

[miczyg1]

So presumably something in either the coreboot source (anything of relevance not been upstreamed @miczyg1?) or something in the coreboot config.

Not entirely impossible, but no idea what that might be.

[tlaurion]

@Tonux599 don't forget to add microcode 0x12F released 2 weeks ago.

source : zir_blazer : Dasharo General : https://community.intel.com/t5/Processors/Intel-Core-13th-and-14th-Gen-Vmin-Shift-Instabilty-Update-New/m-p/1686948

[Tonux599]

This is stalled until the stability issue #1962 (comment) is resolved.

Until then the following is what I'm using on my Z790-P (DDR5) board. It uses Dasharo's v0.9.2 release.

https://github.com/Tonux599/heads/tree/my-custom-msi_z790p_ddr5