Skip to content

device_parser: improve error reporting #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

mwasilew
Copy link
Contributor

This patch adds more verbose output to config file parsing errors.

Copy link
Collaborator

@lumag lumag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rephrase commit message to use imperative language. In other words, "This patch adds" -> "Add".

Add more verbose output to config file parsing errors.

Signed-off-by: Milosz Wasilewski <milosz.wasilewski@oss.qualcomm.com>
@mwasilew
Copy link
Contributor Author

Could you please rephrase commit message to use imperative language. In other words, "This patch adds" -> "Add".

Fixed.

I split the long lines, but I'm not sure this is done "the right way". I didn't find any other long lines in the code to follow the style. Let me know what is the preferred way here.

@lumag lumag merged commit 4320c48 into linux-msm:master Feb 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants