cdba: add keys to press/release the fastboot button #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradybcio
reviewed
May 20, 2024
cdba.h
Outdated
| @@ -23,6 +23,8 @@ enum { | |||
| MSG_FASTBOOT_PRESENT, | |||
| MSG_FASTBOOT_DOWNLOAD, | |||
| MSG_FASTBOOT_BOOT, | |||
| MSG_FASTBOOT_BTN_PRESS, | |||
| MSG_FASTBOOT_BTN_RELEASE, | |||
There was a problem hiding this comment.
I don't like the idea of having two messages for a single button. Maybe we should follow something like (MSG_BUTTON <button:u8, state:bool>)?
For some testing it's useful to manually press the fastboot button. Add support for doing this. Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
kcxt
force-pushed
the
caleb/fastboot-button
branch
from
84cfa2f to
58fd0d5
Compare
|
@calebccff any chance of this getting fixed? |
Yes, I kind of did in #83 (with some other changes). |
|
Thanks, closing in favour of #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some testing it's useful to manually press the fastboot button. Add support for doing this with <[C-a] f>