Cargo clippy deny 2025 05 23 #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The advisory[1] says the following about surf:
The last release is over three years old (from 2021), the crate
depends on the deprecated `async-std` crate and on a very old version
of `rustls` for TLS support.
We use `surf` _because_ it is `async-std` based and we use `async-std`
throughout our code base, which means we will throw it out once we bite
the bullet and replace `async-std`.
We only use surf to poll the local `lxa-iobus` REST API, so we do not have
to fear possible security issue so much.
[1]: https://rustsec.org/advisories/RUSTSEC-2025-0036
Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
This makes the code a bit easier to read. The change is based on a clippy lint added in rust 1.87.0. [1]: https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
jluebbe
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had CI build failures today because
cargo denyandcargo clippyhave learned new tricks.Acknowledge that
async-stdand crates based on it are deprecated and apply a change suggested bycargo clippy.