ci: tacd: remove dependencies on actions-rs GitHub actions #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnez
force-pushed
the
remove-actions-rs
branch
from
a385702 to
ffbe080
Compare
|
The failed |
hnez
force-pushed
the
remove-actions-rs
branch
from
ffbe080 to
8d5da67
Compare
The actions-rs GitHub actions are no longer being maintained and started producing warnings on every run some time ago. Since rustup comes pre-installed on the default action runner images we can use it directly to install our toolchain. The current stable channel rust version is also likely already installed on the machine. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
The actions-rs GitHub actions are no longer being maintained and started producing warnings on every run some time ago. We can just call `cargo` ourself instead of relying on an action to do it for us. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
The actions-rs GitHub actions are no longer being maintained and started producing warnings on every run some time ago. We can just call `cargo clippy` ourself instead of relying on an action to do it for us. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
Other than the actions-rs actions the cargo-deny action is actually actively maintained, but replacing it with a simple `cargo deny` call removes our last non-GitHub provided action dependency and makes it a bit easier to determine what is actually happening in the action, should one e.g. want to reproduce it locally. Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
hnez
force-pushed
the
remove-actions-rs
branch
from
8d5da67 to
ee5ff4f
Compare
Emantor
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actions-rs project is no longer maintained and our workflow runs have produced a lot of warnings due to that for some time now.
Remove our dependency on it by calling
rustupandcargoourselves. This also makes the CI scripts easier to read in my opinion and easier to reproduce locally since you can just run the same commands as the CI does.