Skip to content

feat(async)!: migrate to a new simplier/easier async module! #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 2, 2025

Conversation

linrongbin16
Copy link
Owner

@linrongbin16 linrongbin16 commented Jan 31, 2025

There's a break change in lua 5.1/5.2 about coroutine.running() API, which could impact the async module.

This bug could be reproduced in Fedora 41 workstation edition, see linrongbin16/gitlinker.nvim#257 and linrongbin16/gitlinker.nvim#262.


Manually tested here: linrongbin16/gitlinker.nvim#264

@linrongbin16 linrongbin16 changed the title feat(async)!: migrate to a new simplier/easier async module feat(async)!: migrate to a new simplier/easier async module! Jan 31, 2025
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (84bd05c) to head (e04be1a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files          10       10           
  Lines        1334     1334           
=======================================
  Hits         1181     1181           
  Misses        153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@linrongbin16 linrongbin16 merged commit 592432b into main Feb 2, 2025
13 of 14 checks passed
@linrongbin16 linrongbin16 deleted the new-async branch February 2, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant