Skip to content

Conversation

@zliang-akamai
Copy link
Member

📝 Description

Implementing CopyFrom for VPCSubnetModel

✔️ How to Test

make PKG_NAME="vpcsubnet" test-int

@zliang-akamai zliang-akamai requested a review from a team as a code owner September 22, 2025 20:22
@zliang-akamai zliang-akamai requested review from Copilot, jriddle-linode and yec-akamai and removed request for a team September 22, 2025 20:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the CopyFrom method for the VPCSubnetModel struct to facilitate copying values between model instances. The changes also include consistent renaming of variable names from vpcId to vpcID for better Go naming conventions and field name updates from VPCId to VPCID.

  • Added CopyFrom method to VPCSubnetModel for copying field values between instances
  • Renamed variables and struct fields from vpcId/VPCId to vpcID/VPCID for consistency
  • Updated the Update method to use CopyFrom instead of manual attribute retrieval

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
linode/vpcsubnet/framework_resource.go Updated variable names and replaced manual state copying with CopyFrom method call
linode/vpcsubnet/framework_models.go Added CopyFrom method and renamed struct field from VPCId to VPCID
linode/vpcsubnet/framework_datasource.go Updated variable name from vpcId to vpcID for consistency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@zliang-akamai zliang-akamai added the improvement for improvements in existing functionality in the changelog. label Sep 23, 2025
Copy link
Collaborator

@jriddle-linode jriddle-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement for improvements in existing functionality in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants