Added support for Host Maintenance Policy features #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
requested review from
zliang-akamai and
yec-akamai
and removed request for
a team
ezilber-akamai
added
new-feature
|
|
zliang-akamai
approved these changes
Jul 15, 2025
ezilber-akamai
changed the title
yec-akamai
reviewed
Jul 25, 2025
| "github.com/hashicorp/terraform-plugin-framework/datasource/schema" | ||
| ) | ||
|
|
||
| var frameworkDataSourceSchema = schema.Schema{ |
There was a problem hiding this comment.
Looks like it's a listing data source, should we implement the schema including filter, order, etc.? Also might need to make some changes to the data source Read to support filtering.
There was a problem hiding this comment.
The API Spec did not mention any filtering so I wasn't sure if I should implement it or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Added support for Host Maintenance in account settings and instances, and added datasource for maintenance policies.
✔️ How to Test
The following steps assume you have pulled down this PR locally
Unit Tests
make test-unitIntegration Tests
For running the integration tests, you will need to point at DevCloud. Note that the account settings tests will not pass due to limitations with changing account settings for DevCloud accounts.
make test-int PKG_NAME="accountsettings" TEST_CASE="TestAccDataSourceLinodeAccountSettings_basic"make test-int PKG_NAME="accountsettings" TEST_CASE="TestAccResourceAccountSettings_update"make test-int PKG_NAME="instance" TEST_CASE="TestAccDataSourceInstances_basic"make test-int PKG_NAME="instance" TEST_CASE="TestAccResourceInstance_updateMaintenancePolicy"make test-int PKG_NAME="maintenancepolicies" TEST_CASE="TestAccDataSourceMaintenancePolicies_basic"