Skip to content

Conversation

@komer3
Copy link
Contributor

@komer3 komer3 commented Oct 14, 2025

📝 Description

What does this PR do and why is this change necessary?
Adding support for listing and getting specific PrefixList APIs

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

How do I run the relevant unit/integration tests?
Added relevant unit tests (no integration since API is not currently available). Just run make test to verfiy

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@komer3 komer3 marked this pull request as ready for review October 14, 2025 14:25
@komer3 komer3 requested a review from a team as a code owner October 14, 2025 14:25
@komer3 komer3 requested review from Copilot, vshanthe and zliang-akamai and removed request for a team October 14, 2025 14:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for PrefixList APIs by implementing functionality to list and retrieve specific prefix lists from the Linode API.

  • Introduces a new PrefixList struct with all necessary fields and custom JSON unmarshaling for timestamp handling
  • Adds ListPrefixLists and GetPrefixList client methods for API interaction
  • Provides comprehensive unit tests covering list, get, and JSON unmarshaling operations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
prefixlists.go Implements PrefixList struct, custom JSON unmarshaling, and client methods for listing and getting prefix lists
test/unit/prefixlists_test.go Adds comprehensive unit tests for PrefixList operations including list, get, and JSON unmarshaling scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@lgarber-akamai lgarber-akamai self-requested a review October 14, 2025 14:47
@lgarber-akamai
Copy link
Contributor

@komer3 Is there any chance you could re-point this PR at the tmp-firewall-ruleset branch? Once the feature is available in production we can put up a PR to merge that branch into main.

@komer3 komer3 changed the base branch from main to tmp-firewall-ruleset October 23, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants