Fix lint fmt issue and update golangci config

.golangci.yml

@@ -73,11 +73,15 @@ linters:
       - builtin$
       - examples$
 formatters:
+  settings:
+    golines:
+      max-len: 160
   enable:
     - gci
     - gofmt
     - gofumpt
     - goimports
+    - golines
   exclusions:
     generated: lax
     paths:

monitor_services_create_token.go

@@ -16,7 +16,11 @@ type MonitorTokenCreateOptions struct {
 }
 
 // CreateMonitorServiceTokenForServiceType to create token for a given serviceType
-func (c *Client) CreateMonitorServiceTokenForServiceType(ctx context.Context, serviceType string, opts MonitorTokenCreateOptions) (*MonitorServiceToken, error) {
+func (c *Client) CreateMonitorServiceTokenForServiceType(
+	ctx context.Context,
+	serviceType string,
+	opts MonitorTokenCreateOptions,
+) (*MonitorServiceToken, error) {
 	e := formatAPIPath("monitor/services/%s/token", serviceType)
 	return doPOSTRequest[MonitorServiceToken](ctx, c, e, opts)
 }

nodebalancer_config_nodes.go

@@ -90,7 +90,13 @@ func (c *Client) CreateNodeBalancerNode(ctx context.Context, nodebalancerID int,
 }
 
 // UpdateNodeBalancerNode updates the NodeBalancerNode with the specified id
-func (c *Client) UpdateNodeBalancerNode(ctx context.Context, nodebalancerID int, configID int, nodeID int, opts NodeBalancerNodeUpdateOptions) (*NodeBalancerNode, error) {
+func (c *Client) UpdateNodeBalancerNode(
+	ctx context.Context,
+	nodebalancerID int,
+	configID int,
+	nodeID int,
+	opts NodeBalancerNodeUpdateOptions,
+) (*NodeBalancerNode, error) {
 	e := formatAPIPath("nodebalancers/%d/configs/%d/nodes/%d", nodebalancerID, configID, nodeID)
 	return doPUTRequest[NodeBalancerNode](ctx, c, e, opts)
 }

nodebalancer_configs.go

@@ -264,7 +264,12 @@ func (c *Client) CreateNodeBalancerConfig(ctx context.Context, nodebalancerID in
 }
 
 // UpdateNodeBalancerConfig updates the NodeBalancerConfig with the specified id
-func (c *Client) UpdateNodeBalancerConfig(ctx context.Context, nodebalancerID int, configID int, opts NodeBalancerConfigUpdateOptions) (*NodeBalancerConfig, error) {
+func (c *Client) UpdateNodeBalancerConfig(
+	ctx context.Context,
+	nodebalancerID int,
+	configID int,
+	opts NodeBalancerConfigUpdateOptions,
+) (*NodeBalancerConfig, error) {
 	e := formatAPIPath("nodebalancers/%d/configs/%d", nodebalancerID, configID)
 	return doPUTRequest[NodeBalancerConfig](ctx, c, e, opts)
 }
@@ -276,7 +281,12 @@ func (c *Client) DeleteNodeBalancerConfig(ctx context.Context, nodebalancerID in
 }
 
 // RebuildNodeBalancerConfig updates the NodeBalancer with the specified id
-func (c *Client) RebuildNodeBalancerConfig(ctx context.Context, nodeBalancerID int, configID int, opts NodeBalancerConfigRebuildOptions) (*NodeBalancerConfig, error) {
+func (c *Client) RebuildNodeBalancerConfig(
+	ctx context.Context,
+	nodeBalancerID int,
+	configID int,
+	opts NodeBalancerConfigRebuildOptions,
+) (*NodeBalancerConfig, error) {
 	e := formatAPIPath("nodebalancers/%d/configs/%d/rebuild", nodeBalancerID, configID)
 	return doPOSTRequest[NodeBalancerConfig](ctx, c, e, opts)
 }

object_storage_bucket_certs.go

@@ -20,7 +20,11 @@ type ObjectStorageBucketCertUploadOptions struct {
 
 // UploadObjectStorageBucketCert uploads a TLS/SSL Cert to be used with an Object Storage Bucket.
 // Deprecated: Please use UploadObjectStorageBucketCertV2 for all new implementations.
-func (c *Client) UploadObjectStorageBucketCert(ctx context.Context, clusterOrRegionID, bucket string, opts ObjectStorageBucketCertUploadOptions) (*ObjectStorageBucketCert, error) {
+func (c *Client) UploadObjectStorageBucketCert(
+	ctx context.Context,
+	clusterOrRegionID, bucket string,
+	opts ObjectStorageBucketCertUploadOptions,
+) (*ObjectStorageBucketCert, error) {
 	e := formatAPIPath("object-storage/buckets/%s/%s/ssl", clusterOrRegionID, bucket)
 	return doPOSTRequest[ObjectStorageBucketCert](ctx, c, e, opts)
 }
@@ -33,7 +37,11 @@ func (c *Client) GetObjectStorageBucketCert(ctx context.Context, clusterOrRegion
 }
 
 // UploadObjectStorageBucketCert uploads a TLS/SSL Cert to be used with an Object Storage Bucket.
-func (c *Client) UploadObjectStorageBucketCertV2(ctx context.Context, clusterOrRegionID, bucket string, opts ObjectStorageBucketCertUploadOptions) (*ObjectStorageBucketCertV2, error) {
+func (c *Client) UploadObjectStorageBucketCertV2(
+	ctx context.Context,
+	clusterOrRegionID, bucket string,
+	opts ObjectStorageBucketCertUploadOptions,
+) (*ObjectStorageBucketCertV2, error) {
 	e := formatAPIPath("object-storage/buckets/%s/%s/ssl", clusterOrRegionID, bucket)
 	return doPOSTRequest[ObjectStorageBucketCertV2](ctx, c, e, opts)
 }

object_storage_buckets.go

@@ -172,7 +172,11 @@ func (c *Client) DeleteObjectStorageBucket(ctx context.Context, clusterOrRegionI
 }
 
 // Lists the contents of the specified ObjectStorageBucket
-func (c *Client) ListObjectStorageBucketContents(ctx context.Context, clusterOrRegionID, label string, params *ObjectStorageBucketListContentsParams) (*ObjectStorageBucketContent, error) {
+func (c *Client) ListObjectStorageBucketContents(
+	ctx context.Context,
+	clusterOrRegionID, label string,
+	params *ObjectStorageBucketListContentsParams,
+) (*ObjectStorageBucketContent, error) {
 	basePath := formatAPIPath("object-storage/buckets/%s/%s/object-list", clusterOrRegionID, label)
 
 	queryString := ""

object_storage_object.go

@@ -33,7 +33,11 @@ type ObjectStorageObjectACLConfigUpdateOptions struct {
 	ACL  string `json:"acl"`
 }
 
-func (c *Client) CreateObjectStorageObjectURL(ctx context.Context, objectID, label string, opts ObjectStorageObjectURLCreateOptions) (*ObjectStorageObjectURL, error) {
+func (c *Client) CreateObjectStorageObjectURL(
+	ctx context.Context,
+	objectID, label string,
+	opts ObjectStorageObjectURLCreateOptions,
+) (*ObjectStorageObjectURL, error) {
 	e := formatAPIPath("object-storage/buckets/%s/%s/object-url", objectID, label)
 	return doPOSTRequest[ObjectStorageObjectURL](ctx, c, e, opts)
 }
@@ -45,7 +49,11 @@ func (c *Client) GetObjectStorageObjectACLConfig(ctx context.Context, objectID,
 }
 
 // Deprecated: use UpdateObjectStorageObjectACLConfigV2 for new implementations
-func (c *Client) UpdateObjectStorageObjectACLConfig(ctx context.Context, objectID, label string, opts ObjectStorageObjectACLConfigUpdateOptions) (*ObjectStorageObjectACLConfig, error) {
+func (c *Client) UpdateObjectStorageObjectACLConfig(
+	ctx context.Context,
+	objectID, label string,
+	opts ObjectStorageObjectACLConfigUpdateOptions,
+) (*ObjectStorageObjectACLConfig, error) {
 	e := formatAPIPath("object-storage/buckets/%s/%s/object-acl", objectID, label)
 	return doPUTRequest[ObjectStorageObjectACLConfig](ctx, c, e, opts)
 }
@@ -55,7 +63,11 @@ func (c *Client) GetObjectStorageObjectACLConfigV2(ctx context.Context, objectID
 	return doGETRequest[ObjectStorageObjectACLConfigV2](ctx, c, e)
 }
 
-func (c *Client) UpdateObjectStorageObjectACLConfigV2(ctx context.Context, objectID, label string, opts ObjectStorageObjectACLConfigUpdateOptions) (*ObjectStorageObjectACLConfigV2, error) {
+func (c *Client) UpdateObjectStorageObjectACLConfigV2(
+	ctx context.Context,
+	objectID, label string,
+	opts ObjectStorageObjectACLConfigUpdateOptions,
+) (*ObjectStorageObjectACLConfigV2, error) {
 	e := formatAPIPath("object-storage/buckets/%s/%s/object-acl", objectID, label)
 	return doPUTRequest[ObjectStorageObjectACLConfigV2](ctx, c, e, opts)
 }

request_helpers_test.go

@@ -9,12 +9,10 @@ import (
 	"strconv"
 	"testing"
 
-	"github.com/stretchr/testify/require"
-
-	"github.com/linode/linodego/internal/testutil"
-
 	"github.com/google/go-cmp/cmp"
 	"github.com/jarcoal/httpmock"
+	"github.com/linode/linodego/internal/testutil"
+	"github.com/stretchr/testify/require"
 )
 
 type testResultNestedType struct {

test/integration/account_oauth_client_test.go

@@ -4,10 +4,9 @@ import (
 	"context"
 	"testing"
 
-	"github.com/stretchr/testify/assert"
-
 	"github.com/linode/linodego"
 	. "github.com/linode/linodego"
+	"github.com/stretchr/testify/assert"
 )
 
 func TestOAuthClient_GetMissing(t *testing.T) {
@@ -89,7 +88,11 @@ func TestOAuthClients_Reset(t *testing.T) {
 	assert.NotEqual(t, oauthClient.Secret, oauthClientAfterReset.Secret, "Secret should have been reset")
 }
 
-func setupOAuthClient(t *testing.T, createOpts linodego.OAuthClientCreateOptions, fixturesYaml string) (*linodego.Client, *linodego.OAuthClient, func(), error) {
+func setupOAuthClient(
+	t *testing.T,
+	createOpts linodego.OAuthClientCreateOptions,
+	fixturesYaml string,
+) (*linodego.Client, *linodego.OAuthClient, func(), error) {
 	t.Helper()
 	client, fixtureTeardown := createTestClient(t, fixturesYaml)
 	oauthClient, err := client.CreateOAuthClient(context.Background(), createOpts)

test/integration/images_test.go

@@ -6,11 +6,10 @@ import (
 	"slices"
 	"testing"
 
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/require"
-
 	"github.com/dnaeon/go-vcr/recorder"
 	. "github.com/linode/linodego"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 // testImageBytes is a minimal Gzipped image.

test/integration/instance_firewalls_test.go

@@ -27,7 +27,11 @@ func TestInstanceFirewalls_List(t *testing.T) {
 	}
 }
 
-func setupInstanceFirewall(t *testing.T, firewallModifiers []firewallModifier, fixturesYaml string) (*linodego.Client, *linodego.Instance, *linodego.Firewall, error) {
+func setupInstanceFirewall(
+	t *testing.T,
+	firewallModifiers []firewallModifier,
+	fixturesYaml string,
+) (*linodego.Client, *linodego.Instance, *linodego.Firewall, error) {
 	t.Helper()
 	client, firewall, firewallTeardown, err := setupFirewall(t, firewallModifiers, fixturesYaml)
 

test/integration/instances_test.go

@@ -353,9 +353,14 @@ func TestInstance_Disks_List(t *testing.T) {
 }
 
 func TestInstance_Disks_List_WithEncryption(t *testing.T) {
-	client, instance, teardown, err := setupInstance(t, "fixtures/TestInstance_Disks_List_WithEncryption", true, func(c *linodego.Client, ico *linodego.InstanceCreateOptions) {
-		ico.Region = getRegionsWithCaps(t, c, []string{"Disk Encryption"})[0]
-	})
+	client, instance, teardown, err := setupInstance(
+		t,
+		"fixtures/TestInstance_Disks_List_WithEncryption",
+		true,
+		func(c *linodego.Client, ico *linodego.InstanceCreateOptions) {
+			ico.Region = getRegionsWithCaps(t, c, []string{"Disk Encryption"})[0]
+		},
+	)
 	defer teardown()
 	if err != nil {
 		t.Error(err)
@@ -941,7 +946,12 @@ func createInstance(t *testing.T, client *linodego.Client, enableCloudFirewall b
 	return client.CreateInstance(context.Background(), createOpts)
 }
 
-func setupInstance(t *testing.T, fixturesYaml string, EnableCloudFirewall bool, modifiers ...instanceModifier) (*linodego.Client, *linodego.Instance, func(), error) {
+func setupInstance(
+	t *testing.T,
+	fixturesYaml string,
+	EnableCloudFirewall bool,
+	modifiers ...instanceModifier,
+) (*linodego.Client, *linodego.Instance, func(), error) {
 	if t != nil {
 		t.Helper()
 	}
@@ -1008,7 +1018,12 @@ func createInstanceWithoutDisks(
 	return instance, config, teardown, err
 }
 
-func setupInstanceWithoutDisks(t *testing.T, fixturesYaml string, enableCloudFirewall bool, modifiers ...instanceModifier) (*linodego.Client, *linodego.Instance, *linodego.InstanceConfig, func(), error) {
+func setupInstanceWithoutDisks(
+	t *testing.T,
+	fixturesYaml string,
+	enableCloudFirewall bool,
+	modifiers ...instanceModifier,
+) (*linodego.Client, *linodego.Instance, *linodego.InstanceConfig, func(), error) {
 	t.Helper()
 	client, fixtureTeardown := createTestClient(t, fixturesYaml)
 	instance, config, instanceTeardown, err := createInstanceWithoutDisks(t, client, enableCloudFirewall, modifiers...)

test/integration/integration_suite_test.go

@@ -13,11 +13,10 @@ import (
 	"testing"
 	"time"
 
-	"github.com/stretchr/testify/require"
-
 	"github.com/dnaeon/go-vcr/cassette"
 	"github.com/dnaeon/go-vcr/recorder"
 	"github.com/linode/linodego"
+	"github.com/stretchr/testify/require"
 	"golang.org/x/oauth2"
 	"k8s.io/client-go/transport"
 )

test/integration/lke_clusters_acl_test.go

@@ -4,10 +4,9 @@ import (
 	"context"
 	"testing"
 
+	"github.com/linode/linodego"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-
-	"github.com/linode/linodego"
 )
 
 func TestLKECluster_withACL(t *testing.T) {

test/integration/lke_node_pools_test.go

@@ -4,10 +4,9 @@ import (
 	"context"
 	"testing"
 
-	k8scondition "github.com/linode/linodego/k8s/pkg/condition"
-
 	"github.com/google/go-cmp/cmp"
 	"github.com/linode/linodego"
+	k8scondition "github.com/linode/linodego/k8s/pkg/condition"
 )
 
 var testLKENodePoolCreateOpts = linodego.LKENodePoolCreateOptions{
@@ -288,7 +287,11 @@ func TestLKENodePool_CreateWithLabelsAndTaints(t *testing.T) {
 	}
 }
 
-func setupLKENodePool(t *testing.T, fixturesYaml string, nodePoolCreateOpts *linodego.LKENodePoolCreateOptions) (*linodego.Client, *linodego.LKECluster, *linodego.LKENodePool, func(), error) {
+func setupLKENodePool(
+	t *testing.T,
+	fixturesYaml string,
+	nodePoolCreateOpts *linodego.LKENodePoolCreateOptions,
+) (*linodego.Client, *linodego.LKECluster, *linodego.LKENodePool, func(), error) {
 	t.Helper()
 	var fixtureTeardown func()
 	client, lkeCluster, fixtureTeardown, err := setupLKECluster(t, []clusterModifier{func(createOpts *linodego.LKEClusterCreateOptions) {
@@ -359,7 +362,11 @@ func TestLKEEnterpriseNodePoolK8sUpgrade_Update(t *testing.T) {
 	}
 }
 
-func setupLKEEnterpriseNodePool(t *testing.T, fixturesYaml string, nodePoolCreateOpts *linodego.LKENodePoolCreateOptions) (*linodego.Client, *linodego.LKECluster, *linodego.LKENodePool, func(), error) {
+func setupLKEEnterpriseNodePool(
+	t *testing.T,
+	fixturesYaml string,
+	nodePoolCreateOpts *linodego.LKENodePoolCreateOptions,
+) (*linodego.Client, *linodego.LKECluster, *linodego.LKENodePool, func(), error) {
 	t.Helper()
 	var fixtureTeardown func()
 	client, lkeCluster, fixtureTeardown, err := setupLKECluster(t, []clusterModifier{func(createOpts *linodego.LKEClusterCreateOptions) {

test/integration/monitor_metrics_definitions_test.go

@@ -23,7 +23,11 @@ func TestMonitorMetricDefinitions_Get_smoke(t *testing.T) {
 	}
 
 	// Get the metric-definitions by serviceType for the filter "is_alertable":false
-	monitorMetricDefinitionsClientListFilter, listErr := client.ListMonitorMetricsDefinitionByServiceType(context.Background(), "dbaas", linodego.NewListOptions(0, "{\"is_alertable\":false}"))
+	monitorMetricDefinitionsClientListFilter, listErr := client.ListMonitorMetricsDefinitionByServiceType(
+		context.Background(),
+		"dbaas",
+		linodego.NewListOptions(0, "{\"is_alertable\":false}"),
+	)
 	if listErr != nil {
 		t.Errorf("Error listing monitor metrics:%s", listErr)
 	}