Skip to content

Conversation

@zliang-akamai
Copy link
Member

@zliang-akamai zliang-akamai commented Nov 12, 2024

📝 Description

recvcheck requires receiver type of each method of the same struct to be the same, which is not realistic for our SDK.

Also removed some EOL linters.

@zliang-akamai zliang-akamai requested a review from a team as a code owner November 12, 2024 17:09
@zliang-akamai zliang-akamai requested review from a team, ezilber-akamai, jriddle-linode, lgarber-akamai, yec-akamai and ykim-akamai and removed request for a team November 12, 2024 17:09
Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Contributor

@yec-akamai yec-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the linters!

@zliang-akamai zliang-akamai merged commit 86d1af4 into linode:main Nov 12, 2024
7 checks passed
@zliang-akamai zliang-akamai added the repo-ci-improvement for improvements in the repository or CI workflow in the changelog. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

repo-ci-improvement for improvements in the repository or CI workflow in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants