Drop Resty as a dependency #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezilber-akamai
force-pushed
the
TPT-2965-drop-resty
branch
from
52823e7 to
92c4da8
Compare
ezilber-akamai
added
the
improvement
ezilber-akamai
force-pushed
the
TPT-2965-drop-resty
branch
4 times, most recently
from
bc4dc02 to
519fdcd
Compare
ezilber-akamai
force-pushed
the
TPT-2965-drop-resty
branch
3 times, most recently
from
27bad2e to
117b42b
Compare
ezilber-akamai
force-pushed
the
TPT-2965-drop-resty
branch
5 times, most recently
from
2fa956d to
b584283
Compare
ezilber-akamai
force-pushed
the
TPT-2965-drop-resty
branch
from
c813c02 to
8cbafb0
Compare
ezilber-akamai
force-pushed
the
TPT-2965-drop-resty
branch
from
39f6fed to
daa932b
Compare
ezilber-akamai
force-pushed
the
TPT-2965-drop-resty
branch
from
daa932b to
77adeb4
Compare
ezilber-akamai
requested review from
ykim-akamai and
zliang-akamai
and removed request for
a team
* build(deps): bump golang.org/x/text from 0.18.0 to 0.19.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.18.0 to 0.19.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.18.0...v0.19.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Ran make tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ezilber-akamai <ezilber@akamai.com>
* allow some vars to be shared * add target branch * remove target branch * revert to push_request and only run slack notify when push to main
ezilber-akamai
force-pushed
the
TPT-2965-drop-resty
branch
from
d617c7e to
09a3567
Compare
|
I think it was implemented in a previous PR, but would it make sense for |
lgarber-akamai
approved these changes
Oct 10, 2024
ezilber-akamai
force-pushed
the
TPT-2965-drop-resty
branch
2 times, most recently
from
1b2d5e0 to
c47ec39
Compare
ezilber-akamai
force-pushed
the
TPT-2965-drop-resty
branch
from
c47ec39 to
6a71272
Compare
ykim-akamai
approved these changes
Oct 25, 2024
| runs-on: ubuntu-latest | ||
| needs: [test] | ||
| if: always() && github.repository == 'linode/linodego' # Run even if integration tests fail and only on main repository | ||
| if: always() && github.ref == 'refs/heads/main' && github.event_name == 'push' # Run even if integration tests fail and only on main repository |
There was a problem hiding this comment.
Do we want to add the condition github.ref == 'refs/heads/main' && github.event_name == 'push' along with github.repository == 'linode/linodego' to limit slack notifications?
There was a problem hiding this comment.
I think it's already in main? Maybe we can do some main -> proj -> this-branch merges?
zliang-akamai
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Linodego currently uses the go-resty package to manage all HTTP requests made to the API. This includes logic for authentication, JSON marshaling/unmarshaling, request retries, and debug outputs.
Unfortunately this package has caused various issues for linodego users, including:
Because of these issues, Resty is being dropped as a dependency in favor of the mature and widely adopted net/http package.
✔️ How to Test
Run the unit test suite with
make testunitRun the integration test suite with
make testint