Skip to content

Conversation

@komer3
Copy link
Contributor

@komer3 komer3 commented Oct 10, 2025

Adds option to allow kubeconfig handling for sidecars to a single file path using the kubeconfig flag and adds toggles to disable ServiceAccount and RBAC creation for both controller and node (DaemonSet).

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@komer3 komer3 requested review from a team as code owners October 10, 2025 17:47
@github-actions github-actions bot added the new-feature for new features in the changelog. label Oct 10, 2025
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.67%. Comparing base (804c2bd) to head (651522f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   70.67%   70.67%           
=======================================
  Files          24       24           
  Lines        2759     2759           
=======================================
  Hits         1950     1950           
  Misses        681      681           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@komer3 komer3 merged commit 3043c89 into main Oct 13, 2025
11 checks passed
@komer3 komer3 deleted the diable-rbac-sa-controller branch October 13, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants