Skip to content

Conversation

@0xfourzerofour
Copy link
Contributor

@0xfourzerofour 0xfourzerofour commented Jun 2, 2025

General:

Related issue: #433

Currently there is a bunch of hardcoded path in the helm templates which makes it very hard to run k0s or k3s on linode as they have different paths where the data is saved. Without This the csi driver will never register in the cluster and are unable to dynamically assign volumes in linode.

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@0xfourzerofour 0xfourzerofour requested review from a team as code owners June 2, 2025 02:03
Copy link
Contributor

@AshleyDumaine AshleyDumaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.69%. Comparing base (b4710c9) to head (f18d7eb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   70.69%   70.69%           
=======================================
  Files          24       24           
  Lines        2761     2761           
=======================================
  Hits         1952     1952           
  Misses        681      681           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AshleyDumaine AshleyDumaine merged commit 77c64e0 into linode:main Jun 2, 2025
7 of 8 checks passed
@komer3 komer3 added the new-feature for new features in the changelog. label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature for new features in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants